Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement std::error::Error for all error types that implement Display #1089

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

kajacx
Copy link
Contributor

@kajacx kajacx commented Jun 25, 2024

I added an Error impl for all errors that implement Display. I am planning on making another pull request that implements Display and Error for the remaining errors later.

@Robbepop
Copy link
Member

Robbepop commented Jun 25, 2024

@kajacx Hey, thank you this is great! I usually forget to add this trait implementation because in no_std mode it is currently unavailable. However, this is hopefully changing very soon.

It would be great if you could add the trait impls for the missing error types, too.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.48%. Comparing base (5ef1e8d) to head (e20e51a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1089   +/-   ##
=======================================
  Coverage   80.48%   80.48%           
=======================================
  Files         270      270           
  Lines       25080    25080           
=======================================
  Hits        20186    20186           
  Misses       4894     4894           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop changed the title Implement std::error::Error for most errors Implement std::error::Error for all error types that implement Display Jun 25, 2024
@Robbepop
Copy link
Member

I will merge this PR so you can do the planned Display and Error impls in a follow-up PR if you like. :)
Thanks again for your contribution!

@Robbepop Robbepop merged commit aa007b4 into wasmi-labs:master Jun 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants