Start tracking workspace Cargo.lock
#1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did not track Cargo.lock because Wasmi started out as a pure library. However, with the not-so-recent addition of the Wasmi CLI binary we should also start tracking Cargo.lock as is recommended for binary crates.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1096 +/- ##
=======================================
Coverage 80.48% 80.48%
=======================================
Files 270 270
Lines 25079 25079
=======================================
Hits 20184 20184
Misses 4895 4895 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not track
Cargo.lockbecause Wasmi started out as a pure library. However, with the not-so-recent addition of the Wasmi CLI binary we should also start trackingCargo.lockas is recommended for binary crates.Note:
Cargo.lockis ignored when building Wasmi as a crate dependency for users. With a trackedCargo.lockusers can now build the Wasmi CLI tool with--lockeddependencies for reliable builds.