Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rust-cache GitHub action in Wasmi's CI #1098

Merged
merged 9 commits into from
Jul 1, 2024
Merged

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jul 1, 2024

The problem with the current cargo-cache setup is that it still re-compiles all crates each run and only avoids re-downloading all the dependencies.
The rust-cache GitHub action promises to also avoid re-compiling all dependencies.

This PR also fixes incorrect target/corpus directories for the fuzzing CI jobs.

Link: https://github.com/Swatinem/rust-cache

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.48%. Comparing base (ece0757) to head (538f145).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1098   +/-   ##
=======================================
  Coverage   80.48%   80.48%           
=======================================
  Files         270      270           
  Lines       25079    25079           
=======================================
  Hits        20184    20184           
  Misses       4895     4895           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop
Copy link
Member Author

Robbepop commented Jul 1, 2024

Results: we dropped CI times from sometimes well over 15 min to roughly 4-5 minutes.
Especially the test jobs improved substantially and are now at around 1-2 minutes due to non-optimizing test builds.
Also fuzzing jobs now finally properly cache their build and corpus artifacts.

@Robbepop Robbepop merged commit 2024ce7 into main Jul 1, 2024
18 checks passed
@Robbepop Robbepop deleted the rf-use-rust-cache branch July 1, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant