Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wasmi::Module implement Clone #1130

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Make wasmi::Module implement Clone #1130

merged 1 commit into from
Jul 13, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jul 13, 2024

This mirrors the fact that Wasmtime's Module is also Clone which is reflected by the standardized Wasm C-API that views Wasm modules as reference types which are generally cheaply clone-able.

Benchmarks conducted locally didn't show any significant performance regressions. There were a few minor 2% perf regressions which could have also been noise.

@Robbepop Robbepop changed the title Make wasmi::Module: Clone Make wasmi::Module implement Clone Jul 13, 2024
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.56%. Comparing base (b957725) to head (68e5506).

Files Patch % Lines
crates/wasmi/src/module/mod.rs 81.08% 7 Missing ⚠️
crates/wasmi/src/module/export.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
- Coverage   80.56%   80.56%   -0.01%     
==========================================
  Files         273      273              
  Lines       25080    25085       +5     
==========================================
+ Hits        20206    20210       +4     
- Misses       4874     4875       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 258bfd2 into main Jul 13, 2024
18 checks passed
@Robbepop Robbepop deleted the rf-make-module-clone branch July 13, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant