Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use named fields for {Elem,Data}Drop instructions #1182

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

Robbepop
Copy link
Member

Simplifies integration of #1152.

@Robbepop Robbepop mentioned this pull request Sep 17, 2024
8 tasks
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.65%. Comparing base (40b5f74) to head (505c0ff).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/bytecode/visit_regs.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1182   +/-   ##
=======================================
  Coverage   79.64%   79.65%           
=======================================
  Files         298      298           
  Lines       25292    25295    +3     
=======================================
+ Hits        20145    20149    +4     
+ Misses       5147     5146    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 16bd953 into main Sep 17, 2024
16 of 18 checks passed
@Robbepop Robbepop deleted the rf-use-named-fields-for-elem-data-drop branch September 17, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant