Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-hash-maps crate feature to wasmi_cli + enable by default #1225

Merged
merged 4 commits into from
Oct 6, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Oct 5, 2024

This usually has a positive effect on performance and memory usage, especially on smaller and medium sized Wasm binaries.

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.50%. Comparing base (e6fe69b) to head (387931c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
+ Coverage   81.37%   81.50%   +0.12%     
==========================================
  Files         303      303              
  Lines       25015    25008       -7     
==========================================
+ Hits        20357    20383      +26     
+ Misses       4658     4625      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop changed the title Use no-hash-maps crate feature in wasmi_cli Add no-hash-maps crate feature to wasmi_cli + enable by default Oct 6, 2024
@Robbepop Robbepop merged commit 7f3cf05 into main Oct 6, 2024
19 checks passed
@Robbepop Robbepop deleted the rf-use-no-hash-maps-feature-for-cli branch October 6, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant