Fix Float::{min,max} implementations #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add regression unit tests for both operations. Now both operations adhere to the Wasm specification.
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 80.00% 80.07% +0.06%
==========================================
Files 30 30
Lines 4672 4688 +16
==========================================
+ Hits 3738 3754 +16
Misses 934 934
Continue to review full report at Codecov.
|
athei
approved these changes
Jan 3, 2022
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jul 12, 2022
This fixes a bug recently found on oss-fuzz which was fixed in wasmi-labs/wasmi#295 and wasmi-labs/wasmi#293.
alexcrichton
added a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Jul 12, 2022
This fixes a bug recently found on oss-fuzz which was fixed in wasmi-labs/wasmi#295 and wasmi-labs/wasmi#293.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered this while writing Wasm spec test suite for
v1engine.As in #293 the Wasm spec test suite for
v0seem to not properly handle catch these cases and therefore they remained unnoticed.Also add regression unit tests for both operations.
Now both operations adhere to the Wasm specification.