Cleanup workspace organization & benchmarks #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the superflous `_v1` suffix from all benchmarks. Also this renames `compile_and_validate` to just `translate` and also adds what exactly it `translates` or `instantiates` to allow for future additions.
CRITERION BENCHMARKS
|
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 73 73
Lines 6255 6255
=======================================
Hits 4951 4951
Misses 1304 1304 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Also rename "wasmi_v1" folder to just "wasmi".
|
Benchmarking CI will start working again with the next PR. It does not work for this PR in particular since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.