Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make branch instructions offset program counter by delta (PR) #478

Merged
merged 15 commits into from
Sep 27, 2022
Merged

Make branch instructions offset program counter by delta (PR) #478

merged 15 commits into from
Sep 27, 2022

Commits on Sep 26, 2022

  1. rename InstructionIdx -> Instr

    @Robbepop
    Robbepop committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    25b7982 View commit details
    Browse the repository at this point in the history

  2. rename LabelIdx -> LabelRef

    @Robbepop
    Robbepop committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    7041399 View commit details
    Browse the repository at this point in the history

  3. rename some label methods

    @Robbepop
    Robbepop committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    559376e View commit details
    Browse the repository at this point in the history

  4. split Instruction into IrInstruction and ExecInstruction 

    We have not yet introduced an actual difference between them in this commit.
    @Robbepop
    Robbepop committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    72a6416 View commit details
    Browse the repository at this point in the history

  5. remove superflous newline

    @Robbepop
    Robbepop committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    f1486fa View commit details
    Browse the repository at this point in the history

  6. rename Target -> BranchParams 

    Also rename
- BranchParams::destination_pc -> target
- BranchParams::update_destination_pc -> update_target
    @Robbepop
    Robbepop committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    27fcf87 View commit details
    Browse the repository at this point in the history

  7. introduce LabelRegistry

    @Robbepop
    Robbepop committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    0146fda View commit details
    Browse the repository at this point in the history

  8. remove commented out code

    @Robbepop
    Robbepop committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    274069e View commit details
    Browse the repository at this point in the history

  9. cleanup LabelRegistry

    @Robbepop
    Robbepop committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    4b0fbce View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. add BranchParams and BranchOffset types

    @Robbepop
    Robbepop committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    f7bb933 View commit details
    Browse the repository at this point in the history

  2. add LabelUser type and LabelRegistry::try_resolve_label method

    @Robbepop
    Robbepop committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    3fc068a View commit details
    Browse the repository at this point in the history

  3. implement BranchParams and BranchOffset abstractions 

    This makes Instruction again a non-generic type.
Label users are now stored again but in a single Vec to allow for proper heap memory reuse.
Branch targets are now branch offsets since that is going to support a single instruction pointer design in the future.
    @Robbepop
    Robbepop committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    b4b69b4 View commit details
    Browse the repository at this point in the history

  4. fix unit tests

    @Robbepop
    Robbepop committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    ec81eb4 View commit details
    Browse the repository at this point in the history

  5. fix internal doc link

    @Robbepop
    Robbepop committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    b2d609a View commit details
    Browse the repository at this point in the history

  6. add back proper size_of_instruction unit test

    @Robbepop
    Robbepop committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    6d60370 View commit details
    Browse the repository at this point in the history