Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InstructionPtr abstraction (take 2) #482

Merged
merged 7 commits into from
Sep 28, 2022
Merged

Conversation

Robbepop
Copy link
Member

Closes #479.

@Robbepop Robbepop changed the title Add InstructionPtr abstraction (take 2) Add InstructionPtr abstraction (take 2) Sep 28, 2022
@paritytech-cicd-pr
Copy link

CRITERION BENCHMARKS

BENCHMARK MASTER PR Diff
execute/count_until 2.0961 ms 2.0421 ms 🟢 -2.4563 %
execute/factorial_iterative 1.7098 µs 1.523 µs 🟢 -10.8765 %
execute/factorial_recursive 2.2433 µs 2.0744 µs 🟢 -7.5794 %
execute/fib_iterative 10.19 ms 9.8127 ms 🟢 -3.4878 %
execute/fib_recursive 20.4881 ms 18.6807 ms 🟢 -9.7933 %
execute/global_bump 3.8591 ms 3.5449 ms 🟢 -7.9705 %
execute/host_calls 35.2978 µs 33.3171 µs 🟢 -5.5321 %
execute/memory_fill 9.4644 ms 8.1934 ms 🟢 -13.3865 %
execute/memory_sum 9.1463 ms 7.9282 ms 🟢 -13.3186 %
execute/memory_vec_add 16.0485 ms 14.8528 ms 🟢 -7.3883 %
execute/recursive_is_even 3.3526 ms 2.6447 ms 🟢 -20.9188 %
execute/recursive_ok 404.863 µs 390.0931 µs 🟢 -3.5266 %
execute/recursive_scan 523.6289 µs 485.4884 µs 🟢 -7.5352 %
execute/recursive_trap 39.4519 µs 39.285 µs ⚪ -0.332 %
execute/regex_redux 3.5605 ms 3.3738 ms 🟢 -5.4045 %
execute/rev_complement 3.1501 ms 3.0066 ms 🟢 -4.5125 %
execute/tiny_keccak 2.6625 ms 2.6299 ms 🟢 -1.2246 %
execute/trunc_f2i 3.7005 ms 3.5182 ms 🟢 -4.7955 %
instantiate/wasm_kernel 76.7078 µs 77.726 µs ⚪ +1.3078 %
translate/wasm_kernel 6.077 ms 6.1862 ms ⚪ +1.453 %

Link to pipeline

@Robbepop Robbepop merged commit daa6de3 into master Sep 28, 2022
@Robbepop Robbepop deleted the rf-instruction-ptr-v2 branch September 28, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use InstructionPtr instead of a program counter (usize)
2 participants