Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add eval_top3 to keep same style with eval_top/eval_top2 #542

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

yjhmelody
Copy link
Contributor

No description provided.

@Robbepop Robbepop changed the title chore: add eval_top3 to keep same style with eval_top/eval_top2 refactor: add eval_top3 to keep same style with eval_top/eval_top2 Oct 28, 2022
@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.27ms 1.28ms ⚪ 0.19% 1.12ms 1.12ms ⚪ -0.05% 🟢 -12%
execute/
bare_call_0/typed
698.82µs 698.84µs ⚪ 0.02% 561.79µs 561.55µs ⚪ 0.02% 🟢 -20%
execute/
bare_call_1
1.40ms 1.40ms 🔴 0.12% 1.37ms 1.37ms 🟢 -0.65% 🟢 -3%
execute/
bare_call_16
3.04ms 3.18ms 🔴 4.22% 5.00ms 5.01ms ⚪ 0.34% 🟡 58%
execute/
bare_call_16/typed
1.33ms 1.34ms ⚪ 1.02% 2.34ms 2.33ms ⚪ -0.61% 🟡 74%
execute/
bare_call_1/typed
799.56µs 799.94µs ⚪ 0.01% 883.94µs 870.70µs 🟢 -1.51% 🟢 9%
execute/
bare_call_4
1.75ms 1.76ms ⚪ 0.00% 2.14ms 2.13ms 🟢 -0.35% 🟢 21%
execute/
bare_call_4/typed
890.41µs 891.47µs ⚪ 0.15% 1.01ms 998.61µs 🟢 -1.27% 🟢 12%
execute/
br_table
908.27µs 911.05µs ⚪ 0.29% 1.18ms 1.14ms 🟢 -3.30% 🟢 26%
execute/
count_until
902.72µs 903.44µs ⚪ 0.08% 2.40ms 2.40ms ⚪ -0.12% 🔴 166%
execute/
factorial_iterative
458.48µs 364.65µs 🟢 -20.47% 951.48µs 947.40µs ⚪ -0.29% 🔴 160%
execute/
factorial_recursive
739.80µs 721.19µs 🟢 -2.49% 1.58ms 1.53ms 🟢 -3.13% 🔴 112%
execute/
fib_iterative
1.79ms 1.79ms ⚪ 0.09% 4.99ms 5.12ms 🔴 2.46% 🔴 186%
execute/
fib_recursive
7.46ms 7.02ms 🟢 -5.92% 14.68ms 14.30ms 🟢 -2.62% 🔴 104%
execute/
global_bump
1.36ms 1.36ms ⚪ 0.04% 3.70ms 3.65ms 🟢 -1.17% 🔴 168%
execute/
global_const
999.23µs 1.00ms ⚪ -0.03% 2.83ms 2.83ms ⚪ 0.19% 🔴 183%
execute/
host_calls
32.64µs 32.67µs ⚪ 0.05% 45.89µs 44.62µs 🟢 -2.49% 🟢 37%
execute/
memory_fill
1.57ms 1.55ms 🟢 -1.35% 4.21ms 4.20ms ⚪ -0.17% 🔴 171%
execute/
memory_sum
1.55ms 1.57ms ⚪ 1.07% 4.18ms 4.18ms ⚪ -0.10% 🔴 166%
execute/
memory_vec_add
3.08ms 3.07ms ⚪ 0.00% 8.76ms 8.78ms ⚪ 0.18% 🔴 186%
execute/
recursive_is_even
1.30ms 1.29ms ⚪ -0.55% 2.64ms 2.63ms ⚪ -0.20% 🔴 103%
execute/
recursive_ok
172.46µs 170.72µs ⚪ -0.94% 369.02µs 359.71µs 🟢 -2.56% 🔴 111%
execute/
recursive_scan
215.23µs 217.58µs ⚪ 0.98% 473.63µs 465.26µs 🟢 -1.92% 🔴 114%
execute/
recursive_trap
17.03µs 16.89µs ⚪ -0.72% 35.98µs 36.07µs ⚪ 0.41% 🔴 114%
execute/
regex_redux
663.83µs 659.43µs ⚪ -0.62% 1.59ms 1.61ms ⚪ 0.97% 🔴 144%
execute/
rev_complement
592.70µs 594.46µs ⚪ 0.32% 1.56ms 1.56ms ⚪ -0.23% 🔴 162%
execute/
tiny_keccak
476.16µs 469.18µs ⚪ -1.65% 1.40ms 1.37ms 🟢 -2.35% 🔴 192%
execute/
trunc_f2i
1.08ms 1.08ms ⚪ -0.25% 2.66ms 2.69ms 🔴 1.44% 🔴 149%
instantiate/
wasm_kernel
68.13µs 69.17µs ⚪ 1.00% 92.52µs 91.97µs ⚪ -0.13% 🟢 33%
translate/
wasm_kernel
4.15ms 4.22ms 🔴 1.93% 7.75ms 7.78ms ⚪ 0.39% 🟡 84%

Link to pipeline

Copy link
Member

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Robbepop Robbepop merged commit ca8c5c9 into wasmi-labs:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants