-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WASI based on Wasmtime's implementation #557
Conversation
Hi @Robbepop .This basically depends on |
BENCHMARKS
|
@OLUWAMUYIWA from a design perspective this PR looks as I expected it on a surface level which is good. Could you please update to the most recent |
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
==========================================
+ Coverage 79.73% 80.07% +0.34%
==========================================
Files 75 77 +2
Lines 6251 6304 +53
==========================================
+ Hits 4984 5048 +64
+ Misses 1267 1256 -11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the no_std
CI failures we also need to add --exclude wasmi_wasi
to GitHub Action's rust.yml
:
- name: Build wasmi itself as no_std
uses: actions-rs/cargo@v1
with:
command: build
args: --workspace --lib --no-default-features --target thumbv7em-none-eabi --exclude wasmi_cli
wasm-wasi
based on Wasmtime's implementation
wasm-wasi
based on Wasmtime's implementationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks a ton for all the hard work to get partial WASI support for wasmi
@OLUWAMUYIWA !
Let us merge this. 🥳
Closes #358