Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Wasmtime dependency from wasmi_wasi crate #563

Merged
merged 1 commit into from
Nov 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/wasi/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ edition = "2021"

[dependencies]

wasi-common = "2.0.1"
wasi-cap-std-sync = "2.0.1"
wiggle = "2.0.0"
wasi-common = "1.0.0"
wasi-cap-std-sync = "1.0.0"
wiggle = { version = "1.0.0", default-features = false, features = ["wiggle_metadata"] }
wasmi = { version = "0.20.0", path = "../wasmi" }

[dev-dependencies]
Expand Down
50 changes: 50 additions & 0 deletions crates/wasi/src/guest_memory.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
use wiggle::{borrow::BorrowChecker, BorrowHandle, GuestError, GuestMemory, Region};

/// Lightweight `wasmi::Memory` wrapper so we can implement the
/// `wiggle::GuestMemory` trait on it.
pub struct WasmiGuestMemory<'a> {
mem: &'a mut [u8],
bc: BorrowChecker,
}

impl<'a> WasmiGuestMemory<'a> {
pub fn new(mem: &'a mut [u8]) -> Self {
Self {
mem,
// Wiggle does not expose any methods for functions to re-enter
// the WebAssembly instance, or expose the memory via non-wiggle
// mechanisms. However, the user-defined code may end up
// re-entering the instance, in which case this is an incorrect
// implementation - we require exactly one BorrowChecker exist per
// instance.
bc: BorrowChecker::new(),
}
}
}

unsafe impl GuestMemory for WasmiGuestMemory<'_> {
fn base(&self) -> (*mut u8, u32) {
(self.mem.as_ptr() as *mut u8, self.mem.len() as u32)
}
fn has_outstanding_borrows(&self) -> bool {
self.bc.has_outstanding_borrows()
}
fn is_shared_borrowed(&self, r: Region) -> bool {
self.bc.is_shared_borrowed(r)
}
fn is_mut_borrowed(&self, r: Region) -> bool {
self.bc.is_mut_borrowed(r)
}
fn shared_borrow(&self, r: Region) -> Result<BorrowHandle, GuestError> {
self.bc.shared_borrow(r)
}
fn mut_borrow(&self, r: Region) -> Result<BorrowHandle, GuestError> {
self.bc.mut_borrow(r)
}
fn shared_unborrow(&self, h: BorrowHandle) {
self.bc.shared_unborrow(h)
}
fn mut_unborrow(&self, h: BorrowHandle) {
self.bc.mut_unborrow(h)
}
}
2 changes: 2 additions & 0 deletions crates/wasi/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
mod guest_memory;
pub mod snapshots;

pub use self::guest_memory::WasmiGuestMemory;
pub use snapshots::preview_1::define_wasi;
pub use wasi_cap_std_sync::{
clocks,
Expand Down
3 changes: 2 additions & 1 deletion crates/wasi/src/snapshots/preview_1.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use crate::WasmiGuestMemory;
use std::{
pin::Pin,
task::{Context, RawWaker, RawWakerVTable, Waker},
Expand Down Expand Up @@ -64,7 +65,7 @@ macro_rules! impl_add_to_linker_for_funcs {
};
let(mem, ctx) = mem.data_and_store_mut(&mut caller);
let ctx = wasi_ctx(ctx);
let mem = wiggle::wasmtime::WasmtimeGuestMemory::new(mem);
let mem = WasmiGuestMemory::new(mem);

match wasi_common::snapshots::preview_1::wasi_snapshot_preview1::$fname(ctx, &mem, $($arg,)*).await {
Ok(r) => Ok(<$ret>::from(r)),
Expand Down