Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: improve feedback when running a Wasm module without exported functions #584

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

Robbepop
Copy link
Member

No description provided.

@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Nov 30, 2022

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.01ms 1.01ms ⚪ 0.04% 928.99µs 939.11µs ⚪ 0.74% 🟢 -7%
execute/
bare_call_0/typed
526.15µs 525.85µs ⚪ -0.06% 454.16µs 454.23µs ⚪ 0.00% 🟢 -14%
execute/
bare_call_1
1.06ms 1.06ms ⚪ 0.93% 1.19ms 1.23ms 🔴 2.73% 🟢 15%
execute/
bare_call_16
2.20ms 2.18ms ⚪ 0.25% 4.75ms 4.78ms ⚪ 0.82% 🔴 120%
execute/
bare_call_16/typed
1.53ms 1.53ms ⚪ -0.10% 2.37ms 2.38ms ⚪ 0.42% 🟡 56%
execute/
bare_call_1/typed
609.51µs 617.50µs ⚪ 3.23% 770.42µs 796.29µs 🔴 3.30% 🟢 29%
execute/
bare_call_4
1.18ms 1.20ms ⚪ 0.39% 1.95ms 1.97ms ⚪ 1.07% 🟡 64%
execute/
bare_call_4/typed
628.71µs 633.82µs ⚪ 0.64% 877.49µs 873.90µs ⚪ -0.45% 🟢 38%
execute/
br_table
621.51µs 670.64µs ⚪ 5.66% 947.38µs 944.49µs ⚪ -0.23% 🟢 41%
execute/
count_until
650.77µs 651.04µs ⚪ 0.08% 4.81ms 2.06ms 🟢 -57.10% 🔴 217%
execute/
factorial_iterative
310.27µs 305.17µs 🟢 -1.76% 860.31µs 863.64µs ⚪ 0.28% 🔴 183%
execute/
factorial_recursive
626.61µs 606.08µs 🟢 -3.24% 1.31ms 1.31ms ⚪ -0.22% 🔴 116%
execute/
fib_iterative
1.54ms 1.43ms 🟢 -7.20% 4.64ms 4.64ms ⚪ -0.01% 🔴 224%
execute/
fib_recursive
5.99ms 5.73ms 🟢 -4.18% 11.82ms 11.82ms ⚪ -0.09% 🔴 106%
execute/
global_bump
948.28µs 948.78µs ⚪ 0.05% 3.11ms 3.11ms ⚪ 0.15% 🔴 228%
execute/
global_const
716.37µs 716.70µs ⚪ 0.05% 2.36ms 2.36ms ⚪ -0.07% 🔴 229%
execute/
host_calls
28.90µs 28.61µs ⚪ -1.03% 42.26µs 42.96µs 🔴 1.71% 🟢 50%
execute/
memory_fill
1.28ms 1.28ms ⚪ -0.02% 4.10ms 4.10ms ⚪ 0.14% 🔴 221%
execute/
memory_sum
1.25ms 1.31ms 🔴 4.42% 4.12ms 4.12ms ⚪ 0.21% 🔴 215%
execute/
memory_vec_add
2.69ms 2.60ms 🟢 -3.50% 8.46ms 8.45ms ⚪ -0.19% 🔴 226%
execute/
recursive_is_even
1.12ms 1.11ms ⚪ -1.04% 2.14ms 2.13ms ⚪ -0.17% 🟡 92%
execute/
recursive_ok
145.17µs 150.32µs 🔴 3.46% 302.34µs 300.85µs ⚪ -0.47% 🟡 100%
execute/
recursive_scan
178.93µs 178.69µs ⚪ 0.06% 388.68µs 387.35µs ⚪ -0.46% 🔴 117%
execute/
recursive_trap
14.39µs 14.35µs ⚪ -0.12% 30.17µs 30.17µs ⚪ -0.02% 🔴 110%
execute/
regex_redux
542.93µs 542.04µs ⚪ -0.15% 1.52ms 1.53ms ⚪ 0.37% 🔴 182%
execute/
rev_complement
502.83µs 504.82µs ⚪ 0.47% 1.52ms 1.52ms ⚪ -0.26% 🔴 201%
execute/
tiny_keccak
375.47µs 382.53µs ⚪ 1.36% 1.25ms 1.26ms ⚪ 0.29% 🔴 229%
execute/
trunc_f2i
917.25µs 910.15µs ⚪ -0.81% 2.49ms 2.50ms ⚪ 0.19% 🔴 175%
instantiate/
wasm_kernel
61.18µs 56.97µs 🟢 -6.22% 76.86µs 101.36µs 🔴 30.42% 🟡 78%
translate/
erc1155
203.83µs 206.36µs 🔴 1.64% 405.03µs 402.75µs ⚪ -0.50% 🟡 95%
translate/
erc20
100.21µs 100.42µs ⚪ 0.52% 197.31µs 199.77µs ⚪ 1.06% 🟡 99%
translate/
erc721
143.42µs 145.17µs ⚪ 1.40% 288.50µs 288.17µs ⚪ 0.05% 🟡 99%
translate/
spidermonkey
0.00ns 0.00ns ⚪ 0.64% 0.00ns 0.00ns ⚪ -0.26% 🟢 0%
translate/
wasm_kernel
3.73ms 3.73ms ⚪ 0.24% 7.71ms 7.70ms ⚪ 0.02% 🔴 106%

Link to pipeline

@Robbepop Robbepop merged commit f14694f into master Nov 30, 2022
@Robbepop Robbepop deleted the rf-improve-cli-v2 branch November 30, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants