-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow host functions to call Wasm functions #590
Conversation
This will later allow multiple EngineExecutors to share a single read-only EngineResources.
BENCHMARKS
|
…wasm-func-exec # Conflicts: # crates/arena/src/lib.rs # crates/wasmi/src/engine/mod.rs
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
==========================================
+ Coverage 80.70% 80.76% +0.06%
==========================================
Files 79 80 +1
Lines 6364 6416 +52
==========================================
+ Hits 5136 5182 +46
- Misses 1228 1234 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The PR is no longer in WIP phase and is ready to be tested. One remaining thing left to do is to implement stack limits that are based on the offsets of parent call stacks to properly guard against requiring more stack space than has been preconfigured. When this issue is resolved this PR is good to go. |
Since this fix is non trivial and also not super important I decided to do that in another PR and merge this PR as is. |
Closes #572