Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated imported linear memories and tables #593

Merged
merged 4 commits into from
Dec 12, 2022

Conversation

Robbepop
Copy link
Member

Closes #587.

Thanks @yjhmelody for reporting the issue.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.02ms 1.02ms 🟢 0.39% 934.80µs 929.69µs 🟢 -0.26% 🟢 -9%
execute/
bare_call_0/typed
551.39µs 527.15µs 🟢 -4.38% 460.45µs 449.80µs 🟢 -2.43% 🟢 -15%
execute/
bare_call_1
1.07ms 1.05ms 🔴 -2.46% 1.19ms 1.20ms 🔴 0.86% 🟢 14%
execute/
bare_call_16
2.11ms 2.32ms 🔴 9.22% 4.84ms 5.08ms 🔴 5.44% 🔴 119%
execute/
bare_call_16/typed
1.34ms 1.56ms 🔴 17.16% 2.26ms 2.05ms 🟢 -9.51% 🟢 32%
execute/
bare_call_1/typed
610.03µs 609.52µs ⚪ -0.03% 751.53µs 780.36µs 🔴 3.83% 🟢 28%
execute/
bare_call_4
1.18ms 1.20ms 🟢 1.47% 1.92ms 1.85ms 🟢 -3.43% 🟡 54%
execute/
bare_call_4/typed
656.89µs 631.12µs 🟢 -3.78% 904.94µs 908.36µs ⚪ 0.24% 🟢 44%
execute/
br_table
635.09µs 639.56µs ⚪ 2.07% 986.30µs 960.70µs 🟢 -2.63% 🟢 50%
execute/
count_until
711.46µs 651.55µs 🟢 -8.40% 2.19ms 2.19ms ⚪ 0.41% 🔴 236%
execute/
factorial_iterative
301.96µs 314.61µs 🔴 4.00% 862.64µs 863.98µs ⚪ 0.18% 🔴 175%
execute/
factorial_recursive
615.74µs 607.87µs 🟢 -1.30% 1.29ms 1.28ms ⚪ -0.51% 🔴 111%
execute/
fib_iterative
1.43ms 1.55ms 🔴 7.76% 4.62ms 4.62ms ⚪ -0.09% 🔴 199%
execute/
fib_recursive
5.77ms 6.08ms 🔴 5.51% 12.04ms 12.19ms 🔴 1.25% 🔴 101%
execute/
global_bump
1.01ms 957.38µs 🟢 -5.12% 3.24ms 3.20ms 🟢 -1.34% 🔴 234%
execute/
global_const
718.36µs 799.44µs 🔴 11.41% 2.59ms 2.62ms ⚪ 0.85% 🔴 227%
execute/
host_calls
29.00µs 29.08µs ⚪ 0.26% 42.44µs 41.73µs ⚪ -1.58% 🟢 43%
execute/
memory_fill
1.31ms 1.30ms ⚪ -0.36% 4.18ms 4.17ms ⚪ -0.19% 🔴 220%
execute/
memory_sum
1.31ms 1.33ms 🔴 2.27% 4.20ms 4.10ms 🟢 -2.68% 🔴 207%
execute/
memory_vec_add
2.69ms 2.74ms 🔴 1.96% 8.50ms 8.47ms ⚪ -0.39% 🔴 209%
execute/
recursive_is_even
1.18ms 1.13ms 🟢 -3.63% 2.10ms 2.11ms ⚪ 0.16% 🟡 86%
execute/
recursive_ok
146.06µs 145.05µs ⚪ -1.21% 297.98µs 306.25µs 🔴 2.54% 🔴 111%
execute/
recursive_scan
185.71µs 178.46µs 🟢 -4.04% 380.08µs 388.41µs 🔴 2.19% 🔴 118%
execute/
recursive_trap
14.24µs 13.97µs 🟢 -2.15% 29.88µs 30.10µs ⚪ 0.88% 🔴 115%
execute/
regex_redux
543.38µs 554.37µs 🔴 2.25% 1.54ms 1.55ms ⚪ 0.45% 🔴 180%
execute/
rev_complement
500.56µs 519.70µs 🔴 3.71% 1.49ms 1.53ms 🔴 2.82% 🔴 195%
execute/
tiny_keccak
360.96µs 370.64µs 🔴 2.95% 1.21ms 1.22ms ⚪ 0.53% 🔴 228%
execute/
trunc_f2i
919.68µs 916.65µs ⚪ -0.26% 2.52ms 2.51ms ⚪ -0.15% 🔴 174%
instantiate/
wasm_kernel
59.73µs 60.00µs ⚪ 1.83% 75.35µs 93.27µs 🔴 23.18% 🟡 55%
translate/
erc1155
207.26µs 207.41µs ⚪ 0.11% 405.38µs 397.52µs 🟢 -2.03% 🟡 92%
translate/
erc20
101.70µs 101.93µs ⚪ 0.35% 198.34µs 196.73µs ⚪ -0.85% 🟡 93%
translate/
erc721
145.66µs 146.28µs ⚪ 0.02% 289.61µs 283.84µs 🟢 -1.86% 🟡 94%
translate/
spidermonkey
0.00ns 0.00ns ⚪ -1.15% 0.00ns 0.00ns ⚪ -0.99% 🟢 0%
translate/
wasm_kernel
3.80ms 3.75ms ⚪ -0.86% 7.56ms 7.49ms ⚪ -0.94% 🟡 99%

Link to pipeline

@Robbepop Robbepop merged commit f82ed77 into master Dec 12, 2022
@Robbepop Robbepop deleted the rf-fix-duplicated-imported-entities branch December 12, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extract_imports and extract_memories do push_memory duplicated inModule::instantiate
2 participants