Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup wasmi_core crate #607

Merged
merged 6 commits into from
Jan 7, 2023
Merged

Cleanup wasmi_core crate #607

merged 6 commits into from
Jan 7, 2023

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jan 7, 2023

No description provided.

Apparently those bounds are unused across the crate.
Using standard traits is superior to having custom ones where possible.
The UntypedValue API is enough for external users of the crate.
@Robbepop Robbepop changed the title Cleanup wasmi core crate Cleanup wasmi_core crate Jan 7, 2023
@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Jan 7, 2023

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.34ms 1.35ms 🔴 0.16% 1.20ms 1.13ms 🟢 -5.68% 🟢 -16%
execute/
bare_call_0/typed
976.83µs 995.37µs 🔴 1.81% 719.18µs 719.20µs ⚪ 0.03% 🟢 -28%
execute/
bare_call_1
1.42ms 1.42ms ⚪ 0.52% 1.34ms 1.34ms ⚪ -0.28% 🟢 -6%
execute/
bare_call_16
2.44ms 2.45ms ⚪ 0.63% 4.19ms 4.19ms ⚪ -0.17% 🟡 71%
execute/
bare_call_16/typed
1.58ms 1.59ms ⚪ 0.24% 2.34ms 2.33ms ⚪ -0.42% 🟢 47%
execute/
bare_call_1/typed
1.06ms 1.08ms ⚪ 2.77% 1.08ms 1.08ms ⚪ -0.72% 🟢 -0%
execute/
bare_call_4
1.56ms 1.53ms 🟢 -1.92% 1.97ms 1.97ms 🟢 -0.01% 🟢 29%
execute/
bare_call_4/typed
1.09ms 1.09ms ⚪ -0.02% 1.19ms 1.17ms 🟢 -1.89% 🟢 7%
execute/
br_table
1.10ms 1.09ms ⚪ -0.90% 1.36ms 1.29ms 🟢 -4.72% 🟢 18%
execute/
count_until
686.83µs 682.10µs ⚪ -1.03% 2.16ms 2.19ms 🔴 1.83% 🔴 222%
execute/
factorial_iterative
322.34µs 321.97µs ⚪ -0.07% 882.88µs 880.77µs ⚪ -0.26% 🔴 174%
execute/
factorial_recursive
650.69µs 648.24µs ⚪ -0.40% 1.51ms 1.56ms 🔴 3.52% 🔴 141%
execute/
fib_iterative
1.43ms 1.44ms ⚪ 0.61% 4.80ms 4.63ms 🟢 -3.52% 🔴 221%
execute/
fib_recursive
5.71ms 5.85ms 🔴 1.83% 13.40ms 13.16ms 🟢 -1.64% 🔴 125%
execute/
global_bump
1.07ms 1.07ms ⚪ -0.05% 3.21ms 3.21ms ⚪ 0.08% 🔴 199%
execute/
global_const
717.81µs 717.46µs ⚪ -0.03% 2.49ms 2.52ms ⚪ 1.32% 🔴 251%
execute/
host_calls
29.13µs 29.42µs ⚪ 1.01% 42.22µs 42.62µs ⚪ 1.10% 🟢 45%
execute/
memory_fill
1.30ms 1.31ms ⚪ 0.17% 4.12ms 4.12ms ⚪ 0.20% 🔴 216%
execute/
memory_sum
1.32ms 1.31ms ⚪ -0.94% 4.22ms 4.21ms ⚪ -0.19% 🔴 221%
execute/
memory_vec_add
2.66ms 2.66ms ⚪ 0.08% 8.56ms 8.56ms ⚪ 0.00% 🔴 222%
execute/
recursive_is_even
1.16ms 1.17ms ⚪ 0.95% 2.37ms 2.38ms ⚪ 0.42% 🔴 103%
execute/
recursive_ok
143.79µs 144.00µs ⚪ 0.14% 335.75µs 333.22µs ⚪ -0.91% 🔴 131%
execute/
recursive_scan
181.57µs 179.67µs ⚪ -2.46% 438.60µs 439.60µs ⚪ 0.25% 🔴 145%
execute/
recursive_trap
14.17µs 14.12µs ⚪ -0.19% 31.66µs 32.07µs 🔴 1.32% 🔴 127%
execute/
regex_redux
563.07µs 550.20µs 🟢 -2.47% 1.57ms 1.57ms ⚪ -0.23% 🔴 185%
execute/
rev_complement
511.72µs 508.87µs ⚪ 5.98% 1.53ms 1.52ms ⚪ -0.31% 🔴 199%
execute/
tiny_keccak
364.03µs 368.40µs ⚪ 1.03% 1.25ms 1.23ms ⚪ -0.89% 🔴 234%
execute/
trunc_f2i
956.42µs 916.39µs ⚪ -2.23% 2.63ms 2.62ms ⚪ -0.50% 🔴 186%
instantiate/
wasm_kernel
60.15µs 60.07µs ⚪ -0.57% 72.17µs 71.46µs ⚪ 0.15% 🟢 19%
translate/
erc1155
212.74µs 212.10µs ⚪ 0.17% 402.35µs 404.07µs ⚪ 0.40% 🟡 91%
translate/
erc20
102.90µs 104.27µs 🔴 1.70% 196.97µs 200.30µs 🔴 1.87% 🟡 92%
translate/
erc721
148.73µs 149.71µs ⚪ 0.36% 285.26µs 289.53µs 🔴 1.50% 🟡 93%
translate/
spidermonkey
0.00ns 0.00ns ⚪ -0.31% 0.00ns 0.00ns ⚪ 0.72% 🟢 0%
translate/
wasm_kernel
3.85ms 3.87ms ⚪ 1.04% 7.62ms 7.65ms ⚪ 0.57% 🟡 98%

Link to pipeline

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

Merging #607 (4073867) into master (0d12bff) will decrease coverage by 0.09%.
The diff coverage is 13.79%.

@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
- Coverage   80.95%   80.85%   -0.10%     
==========================================
  Files          82       82              
  Lines        6694     6702       +8     
==========================================
  Hits         5419     5419              
- Misses       1275     1283       +8     
Impacted Files Coverage Δ
crates/wasmi/src/func/into_func.rs 95.45% <ø> (ø)
crates/wasmi/src/module/instantiate/mod.rs 78.37% <0.00%> (ø)
crates/core/src/value.rs 62.31% <14.28%> (-1.87%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit d2069ce into master Jan 7, 2023
@Robbepop Robbepop deleted the rf-cleanup-wasmi-core branch January 7, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants