Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer re-export unused traits from wasmi_core #609

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jan 8, 2023

No description provided.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.33ms 1.44ms 🔴 8.14% 1.23ms 1.19ms 🟢 -3.75% 🟢 -17%
execute/
bare_call_0/typed
983.27µs 993.98µs ⚪ 1.29% 764.48µs 746.13µs 🟢 -1.69% 🟢 -25%
execute/
bare_call_1
1.41ms 1.52ms 🔴 7.76% 1.51ms 1.48ms 🟢 -1.81% 🟢 -3%
execute/
bare_call_16
2.47ms 2.45ms 🔴 -0.51% 4.46ms 4.23ms 🟢 -3.44% 🟡 72%
execute/
bare_call_16/typed
1.56ms 1.65ms 🔴 5.92% 2.30ms 2.28ms ⚪ -0.63% 🟢 38%
execute/
bare_call_1/typed
1.06ms 1.06ms ⚪ 0.00% 1.13ms 1.14ms ⚪ 0.50% 🟢 8%
execute/
bare_call_4
1.52ms 1.61ms 🔴 6.45% 2.05ms 2.00ms 🔴 -3.01% 🟢 24%
execute/
bare_call_4/typed
1.08ms 1.09ms 🔴 1.64% 1.12ms 1.16ms 🔴 3.75% 🟢 7%
execute/
br_table
1.09ms 1.09ms ⚪ 1.34% 1.34ms 1.38ms 🔴 3.13% 🟢 27%
execute/
count_until
711.22µs 710.99µs ⚪ 0.13% 2.24ms 2.24ms ⚪ 0.00% 🔴 215%
execute/
factorial_iterative
321.41µs 321.20µs ⚪ -0.02% 914.41µs 893.77µs ⚪ -8.37% 🔴 178%
execute/
factorial_recursive
640.28µs 635.01µs ⚪ -0.85% 1.72ms 1.68ms 🟢 -2.34% 🔴 165%
execute/
fib_iterative
1.46ms 1.45ms ⚪ 0.02% 4.55ms 4.55ms ⚪ -0.07% 🔴 213%
execute/
fib_recursive
5.80ms 5.80ms ⚪ -0.10% 15.66ms 15.09ms 🟢 -3.69% 🔴 160%
execute/
global_bump
1.10ms 1.10ms ⚪ -0.17% 3.36ms 3.34ms ⚪ -0.64% 🔴 203%
execute/
global_const
718.18µs 718.16µs ⚪ -0.03% 2.63ms 2.52ms 🟢 -4.84% 🔴 251%
execute/
host_calls
29.48µs 29.39µs ⚪ -0.12% 46.58µs 45.41µs 🟢 -2.46% 🟡 54%
execute/
memory_fill
1.35ms 1.35ms ⚪ -0.74% 4.13ms 4.13ms ⚪ 0.11% 🔴 206%
execute/
memory_sum
1.32ms 1.32ms ⚪ 0.45% 4.12ms 4.11ms ⚪ -0.21% 🔴 211%
execute/
memory_vec_add
2.82ms 2.83ms ⚪ 0.14% 8.99ms 8.97ms ⚪ -0.34% 🔴 217%
execute/
recursive_is_even
1.14ms 1.13ms ⚪ -0.37% 2.72ms 2.70ms ⚪ -0.84% 🔴 138%
execute/
recursive_ok
145.19µs 145.34µs ⚪ 0.24% 379.47µs 380.24µs ⚪ 0.02% 🔴 162%
execute/
recursive_scan
187.39µs 180.91µs 🟢 -3.49% 484.25µs 484.76µs ⚪ -0.04% 🔴 168%
execute/
recursive_trap
14.28µs 14.30µs ⚪ 0.22% 36.65µs 39.04µs 🔴 6.23% 🔴 173%
execute/
regex_redux
575.54µs 584.58µs ⚪ 1.35% 1.69ms 1.68ms ⚪ -0.83% 🔴 187%
execute/
rev_complement
536.16µs 534.45µs ⚪ -0.17% 1.56ms 1.57ms ⚪ 0.17% 🔴 193%
execute/
tiny_keccak
373.72µs 374.95µs ⚪ 0.14% 1.26ms 1.26ms ⚪ -0.47% 🔴 236%
execute/
trunc_f2i
911.03µs 911.83µs ⚪ -0.08% 2.54ms 2.53ms ⚪ -0.29% 🔴 178%
instantiate/
wasm_kernel
60.66µs 58.61µs 🟢 -3.68% 70.67µs 71.86µs 🔴 2.49% 🟢 23%
translate/
erc1155
210.71µs 209.26µs ⚪ -0.77% 405.34µs 402.40µs ⚪ -0.77% 🟡 92%
translate/
erc20
102.25µs 102.71µs ⚪ 0.84% 196.92µs 199.15µs ⚪ 0.88% 🟡 94%
translate/
erc721
148.30µs 148.66µs ⚪ 0.43% 287.29µs 286.82µs ⚪ -0.28% 🟡 93%
translate/
spidermonkey
0.00ns 0.00ns ⚪ 0.62% 0.00ns 0.00ns ⚪ 0.35% 🟢 0%
translate/
wasm_kernel
3.81ms 3.81ms ⚪ -0.15% 7.62ms 7.61ms ⚪ 0.28% 🟡 100%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Merging #609 (a08420c) into master (f4aabf3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   80.98%   80.98%           
=======================================
  Files          82       82           
  Lines        6758     6758           
=======================================
  Hits         5473     5473           
  Misses       1285     1285           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit cc05d72 into master Jan 8, 2023
@Robbepop Robbepop deleted the rf-cleanup-wasmi-core branch January 8, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants