Make Engine's executor use &mut StoreInner (making it non-generic)
#611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation to making the engine executor itself use StoreInner.
These APIs were pub(crate) and just used by the engine before which is now using the StoreInner directly instead.
This step required us to save a mapping from Func -> DedupFuncType in the StoreInner itself. So this information is duplicated now between StoreInner and Store<T> since Store<T> already stores a mapping from Func -> FuncEntity<T> where FuncEntity<T> has information about the underlying DedupFuncType. I think this minor information duplication is O.K. for the big gain of a non-generic Engine executor.
Robbepop
changed the title
Engine' executor use &mut StoreInner (making it non-generic)Engine's executor use &mut StoreInner (making it non-generic)
BENCHMARKS
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## master #611 +/- ##
==========================================
- Coverage 80.98% 80.65% -0.33%
==========================================
Files 82 83 +1
Lines 6758 6820 +62
==========================================
+ Hits 5473 5501 +28
- Misses 1285 1319 +34
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR technically prepares
wasmifor using the new#[union_fn]macro.Before this PR the
Engineexecutor was generic over actx: impl AsContextMutwhich is no longer required since theEngineexecutor now works given a non-generic&mut StoreInner. TheStoreInneris a non-generic abstraction of theStore<T>type which holds all the data that is not associated to theTinStore<T>.