Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror Wasmtime APIs more closely #613

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Mirror Wasmtime APIs more closely #613

merged 4 commits into from
Jan 16, 2023

Conversation

Robbepop
Copy link
Member

No description provided.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.36ms 1.36ms ⚪ -0.09% 1.14ms 1.13ms ⚪ -0.67% 🟢 -16%
execute/
bare_call_0/typed
1.00ms 1.01ms ⚪ 0.59% 725.13µs 731.28µs ⚪ 1.05% 🟢 -27%
execute/
bare_call_1
1.43ms 1.49ms 🔴 3.39% 1.42ms 1.38ms 🔴 -2.74% 🟢 -7%
execute/
bare_call_16
2.40ms 2.38ms 🟢 -0.34% 4.20ms 4.10ms 🟢 -2.17% 🟡 72%
execute/
bare_call_16/typed
1.64ms 1.58ms 🟢 -3.42% 2.40ms 2.39ms ⚪ -0.40% 🟡 51%
execute/
bare_call_1/typed
1.09ms 1.10ms ⚪ 0.79% 1.10ms 1.14ms 🔴 3.52% 🟢 4%
execute/
bare_call_4
1.63ms 1.60ms 🟢 -2.35% 1.99ms 1.95ms 🟢 -2.07% 🟢 22%
execute/
bare_call_4/typed
1.11ms 1.11ms ⚪ -0.28% 1.13ms 1.11ms 🟢 -2.22% 🟢 -1%
execute/
br_table
1.12ms 1.10ms ⚪ -1.10% 1.31ms 1.31ms ⚪ 0.17% 🟢 19%
execute/
count_until
645.79µs 645.73µs ⚪ -0.30% 2.11ms 2.11ms ⚪ 0.21% 🔴 227%
execute/
factorial_iterative
325.70µs 327.83µs ⚪ 0.61% 882.21µs 882.07µs ⚪ -0.15% 🔴 169%
execute/
factorial_recursive
631.35µs 637.86µs 🔴 1.17% 1.40ms 1.41ms ⚪ 0.19% 🔴 120%
execute/
fib_iterative
1.43ms 1.50ms 🔴 4.52% 4.64ms 4.63ms ⚪ -0.23% 🔴 209%
execute/
fib_recursive
5.94ms 5.74ms 🟢 -3.45% 12.60ms 12.54ms ⚪ -0.15% 🔴 119%
execute/
global_bump
973.18µs 972.77µs ⚪ 0.07% 3.29ms 3.30ms ⚪ -0.03% 🔴 239%
execute/
global_const
742.19µs 748.40µs ⚪ 1.10% 2.40ms 2.40ms ⚪ -0.01% 🔴 221%
execute/
host_calls
29.30µs 29.04µs ⚪ -1.04% 41.33µs 41.75µs ⚪ 0.76% 🟢 44%
execute/
memory_fill
1.24ms 1.24ms ⚪ 0.03% 3.87ms 3.87ms ⚪ 0.00% 🔴 212%
execute/
memory_sum
1.22ms 1.22ms ⚪ -0.05% 3.89ms 3.89ms ⚪ 0.10% 🔴 219%
execute/
memory_vec_add
2.56ms 2.56ms ⚪ -0.21% 8.31ms 7.98ms 🟢 -4.05% 🔴 212%
execute/
recursive_is_even
1.15ms 1.18ms ⚪ 2.59% 2.27ms 2.28ms ⚪ 0.50% 🟡 94%
execute/
recursive_ok
147.22µs 150.96µs 🔴 2.37% 322.55µs 322.60µs ⚪ -0.22% 🔴 114%
execute/
recursive_scan
179.41µs 179.68µs ⚪ 0.31% 416.64µs 414.78µs ⚪ -0.51% 🔴 131%
execute/
recursive_trap
15.49µs 14.56µs 🟢 -6.18% 32.93µs 33.06µs ⚪ 0.41% 🔴 127%
execute/
regex_redux
537.31µs 533.44µs ⚪ -0.74% 1.49ms 1.49ms ⚪ -1.81% 🔴 179%
execute/
rev_complement
482.83µs 478.80µs ⚪ -0.68% 1.42ms 1.42ms ⚪ 0.23% 🔴 196%
execute/
tiny_keccak
362.60µs 369.33µs ⚪ 2.33% 1.18ms 1.19ms ⚪ 0.73% 🔴 222%
execute/
trunc_f2i
909.98µs 910.31µs ⚪ -0.03% 2.46ms 2.46ms ⚪ -0.17% 🔴 170%
instantiate/
wasm_kernel
65.23µs 65.65µs ⚪ 2.07% 107.79µs 108.08µs ⚪ 0.93% 🟡 65%
translate/
erc1155
209.08µs 210.06µs ⚪ -0.15% 407.73µs 410.74µs ⚪ 0.87% 🟡 96%
translate/
erc20
101.80µs 102.84µs ⚪ 1.12% 199.98µs 204.01µs 🔴 2.24% 🟡 98%
translate/
erc721
148.22µs 146.41µs ⚪ -0.32% 290.33µs 292.91µs ⚪ 1.13% 🟡 100%
translate/
spidermonkey
0.00ns 0.00ns ⚪ -0.55% 0.00ns 0.00ns ⚪ 0.43% 🟢 0%
translate/
wasm_kernel
3.80ms 3.81ms ⚪ 0.21% 7.82ms 7.90ms ⚪ 0.92% 🔴 107%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Merging #613 (d37b519) into master (1a5891a) will decrease coverage by 0.11%.
The diff coverage is 10.00%.

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   81.12%   81.00%   -0.12%     
==========================================
  Files          83       83              
  Lines        6855     6865      +10     
==========================================
  Hits         5561     5561              
- Misses       1294     1304      +10     
Impacted Files Coverage Δ
crates/wasmi/src/func/caller.rs 52.94% <0.00%> (ø)
crates/wasmi/src/module/error.rs 26.66% <ø> (ø)
crates/wasmi/src/store.rs 81.56% <11.11%> (-4.83%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit 7c16e77 into master Jan 16, 2023
@Robbepop Robbepop deleted the rf-wasmtime-apis branch January 16, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants