Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Module::get_export method #617

Merged
merged 5 commits into from
Jan 17, 2023
Merged

Implement Module::get_export method #617

merged 5 commits into from
Jan 17, 2023

Conversation

Robbepop
Copy link
Member

This API was still missing since it is available in the Wasmtime API.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.40ms 1.41ms ⚪ 0.41% 1.11ms 1.12ms 🔴 0.22% 🟢 -20%
execute/
bare_call_0/typed
1.01ms 1.01ms ⚪ 0.31% 724.83µs 734.39µs 🔴 1.42% 🟢 -27%
execute/
bare_call_1
1.44ms 1.45ms 🔴 0.25% 1.49ms 1.42ms 🔴 -4.32% 🟢 -2%
execute/
bare_call_16
2.39ms 2.47ms 🔴 3.23% 4.14ms 4.20ms 🔴 1.32% 🟡 70%
execute/
bare_call_16/typed
1.54ms 1.59ms 🔴 2.82% 2.39ms 2.48ms 🔴 4.07% 🟡 56%
execute/
bare_call_1/typed
1.09ms 1.11ms 🔴 1.88% 1.07ms 1.10ms 🔴 2.71% 🟢 -1%
execute/
bare_call_4
1.60ms 1.62ms ⚪ 1.07% 2.01ms 1.99ms 🔴 -1.29% 🟢 23%
execute/
bare_call_4/typed
1.11ms 1.12ms ⚪ 0.33% 1.13ms 1.17ms 🔴 3.06% 🟢 4%
execute/
br_table
1.11ms 1.18ms 🔴 4.57% 1.25ms 1.27ms 🔴 1.50% 🟢 8%
execute/
count_until
651.99µs 682.03µs 🔴 4.67% 2.12ms 2.12ms ⚪ -0.21% 🔴 211%
execute/
factorial_iterative
325.47µs 330.28µs ⚪ 1.31% 884.12µs 879.30µs ⚪ -0.45% 🔴 166%
execute/
factorial_recursive
652.54µs 656.38µs ⚪ 0.60% 1.39ms 1.39ms ⚪ 0.31% 🔴 112%
execute/
fib_iterative
1.45ms 1.47ms ⚪ 0.89% 4.64ms 4.64ms ⚪ -0.02% 🔴 216%
execute/
fib_recursive
5.67ms 5.77ms 🔴 1.86% 12.43ms 12.39ms ⚪ -0.20% 🔴 115%
execute/
global_bump
976.06µs 1.01ms 🔴 3.58% 3.28ms 3.30ms ⚪ 0.59% 🔴 226%
execute/
global_const
742.65µs 719.11µs 🟢 -3.27% 2.40ms 2.40ms ⚪ -0.04% 🔴 233%
execute/
host_calls
28.95µs 29.20µs ⚪ 1.02% 41.23µs 41.27µs ⚪ -0.10% 🟢 41%
execute/
memory_fill
1.25ms 1.31ms 🔴 4.96% 3.87ms 3.88ms ⚪ 0.07% 🔴 196%
execute/
memory_sum
1.22ms 1.22ms ⚪ -0.31% 3.89ms 3.89ms ⚪ 0.22% 🔴 219%
execute/
memory_vec_add
2.54ms 2.53ms ⚪ -0.18% 7.99ms 7.99ms ⚪ 0.04% 🔴 215%
execute/
recursive_is_even
1.16ms 1.18ms 🔴 1.97% 2.24ms 2.26ms ⚪ 0.87% 🟡 91%
execute/
recursive_ok
159.29µs 153.11µs 🟢 -3.89% 318.69µs 323.49µs 🔴 1.57% 🔴 111%
execute/
recursive_scan
190.77µs 177.85µs 🟢 -6.79% 415.54µs 416.94µs ⚪ 0.25% 🔴 134%
execute/
recursive_trap
14.56µs 14.40µs 🟢 -1.23% 32.83µs 33.11µs ⚪ 0.97% 🔴 130%
execute/
regex_redux
538.13µs 547.47µs 🔴 1.89% 1.52ms 1.49ms 🟢 -1.86% 🔴 173%
execute/
rev_complement
493.77µs 479.24µs 🟢 -3.04% 1.44ms 1.45ms ⚪ 0.25% 🔴 202%
execute/
tiny_keccak
360.06µs 369.34µs 🔴 2.20% 1.18ms 1.20ms 🔴 1.83% 🔴 225%
execute/
trunc_f2i
906.46µs 907.60µs ⚪ 0.00% 2.46ms 2.46ms ⚪ -0.04% 🔴 171%
instantiate/
wasm_kernel
66.36µs 61.48µs 🟢 -8.36% 86.66µs 87.35µs ⚪ 0.02% 🟢 42%
translate/
erc1155
209.91µs 207.64µs 🟢 -1.39% 403.77µs 420.32µs 🔴 4.03% 🔴 102%
translate/
erc20
102.16µs 100.95µs ⚪ -1.10% 197.85µs 206.53µs 🔴 4.53% 🔴 105%
translate/
erc721
148.21µs 144.32µs 🟢 -2.44% 288.12µs 301.09µs 🔴 4.63% 🔴 109%
translate/
spidermonkey
0.00ns 0.00ns ⚪ -0.08% 0.00ns 0.00ns 🔴 3.46% 🟢 0%
translate/
wasm_kernel
3.78ms 3.80ms ⚪ 0.58% 7.70ms 7.94ms 🔴 3.18% 🔴 109%

Link to pipeline

@Robbepop Robbepop merged commit 02b4203 into master Jan 17, 2023
@Robbepop Robbepop deleted the rf-module-get-export branch January 17, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants