Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ModuleError export from crate root #618

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Conversation

Robbepop
Copy link
Member

Now ModuleError lives under crate::errors just like all other error types.

Now ModuleError lives under crate::errors just like all other error types.
@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.43ms 1.41ms 🔴 -1.17% 1.11ms 1.16ms 🔴 4.20% 🟢 -18%
execute/
bare_call_0/typed
994.98µs 1.01ms 🔴 1.22% 730.47µs 770.58µs 🔴 5.66% 🟢 -23%
execute/
bare_call_1
1.46ms 1.44ms 🟢 -1.20% 1.40ms 1.46ms 🔴 4.09% 🟢 1%
execute/
bare_call_16
2.45ms 2.47ms ⚪ 1.08% 4.19ms 4.20ms ⚪ 0.28% 🟡 70%
execute/
bare_call_16/typed
1.65ms 1.62ms ⚪ -1.29% 2.47ms 2.48ms ⚪ 0.82% 🟡 53%
execute/
bare_call_1/typed
1.10ms 1.10ms ⚪ 0.12% 1.09ms 1.21ms 🔴 10.64% 🟢 10%
execute/
bare_call_4
1.66ms 1.65ms 🔴 -0.91% 1.98ms 2.04ms 🔴 3.33% 🟢 24%
execute/
bare_call_4/typed
1.10ms 1.12ms 🔴 1.74% 1.13ms 1.17ms 🔴 3.34% 🟢 5%
execute/
br_table
1.10ms 1.12ms ⚪ 0.72% 1.30ms 1.36ms 🔴 5.09% 🟢 22%
execute/
count_until
682.20µs 681.95µs ⚪ -0.48% 2.12ms 2.13ms ⚪ 0.31% 🔴 212%
execute/
factorial_iterative
326.90µs 329.51µs ⚪ 0.90% 880.88µs 900.49µs 🔴 2.12% 🔴 173%
execute/
factorial_recursive
659.04µs 645.75µs 🟢 -2.01% 1.39ms 1.39ms ⚪ -0.04% 🔴 116%
execute/
fib_iterative
1.43ms 1.47ms 🔴 2.57% 4.62ms 4.63ms ⚪ 0.28% 🔴 215%
execute/
fib_recursive
5.69ms 5.77ms 🔴 1.26% 12.37ms 12.49ms ⚪ 0.93% 🔴 117%
execute/
global_bump
1.01ms 1.01ms ⚪ -0.07% 3.29ms 3.29ms ⚪ 0.03% 🔴 226%
execute/
global_const
716.95µs 719.44µs ⚪ 0.30% 2.40ms 2.40ms ⚪ 0.14% 🔴 233%
execute/
host_calls
31.46µs 29.27µs ⚪ -1.46% 40.82µs 44.25µs 🔴 8.50% 🟡 51%
execute/
memory_fill
1.24ms 1.24ms ⚪ 0.21% 3.88ms 3.87ms ⚪ -0.37% 🔴 211%
execute/
memory_sum
1.22ms 1.22ms ⚪ 0.57% 3.90ms 3.91ms ⚪ -0.03% 🔴 219%
execute/
memory_vec_add
2.54ms 2.54ms ⚪ 0.34% 8.00ms 7.98ms ⚪ -0.22% 🔴 214%
execute/
recursive_is_even
1.25ms 1.21ms 🟢 -4.27% 2.26ms 2.30ms 🔴 1.65% 🟡 90%
execute/
recursive_ok
146.26µs 154.27µs 🔴 5.56% 322.58µs 327.30µs 🔴 1.29% 🔴 112%
execute/
recursive_scan
177.18µs 178.10µs ⚪ 0.51% 415.44µs 417.17µs ⚪ 0.31% 🔴 134%
execute/
recursive_trap
14.51µs 14.64µs ⚪ 0.73% 33.12µs 33.46µs ⚪ 1.12% 🔴 128%
execute/
regex_redux
536.95µs 546.49µs 🔴 1.63% 1.50ms 1.51ms ⚪ 0.33% 🔴 176%
execute/
rev_complement
481.78µs 478.07µs ⚪ -0.64% 1.44ms 1.44ms ⚪ 0.39% 🔴 202%
execute/
tiny_keccak
367.27µs 367.78µs ⚪ -0.36% 1.20ms 1.19ms ⚪ -0.88% 🔴 222%
execute/
trunc_f2i
906.24µs 907.75µs ⚪ 0.16% 2.50ms 2.46ms 🟢 -1.80% 🔴 171%
instantiate/
wasm_kernel
63.62µs 64.15µs ⚪ 0.60% 85.96µs 86.08µs ⚪ 1.05% 🟢 34%
translate/
erc1155
207.54µs 205.62µs ⚪ -1.56% 419.91µs 418.89µs ⚪ -0.22% 🔴 104%
translate/
erc20
101.57µs 100.46µs ⚪ -0.93% 205.01µs 205.95µs ⚪ 0.38% 🔴 105%
translate/
erc721
145.77µs 145.23µs ⚪ -0.61% 297.93µs 298.29µs ⚪ -0.19% 🔴 105%
translate/
spidermonkey
0.00ns 0.00ns ⚪ 0.63% 0.00ns 0.00ns 🟢 -1.23% 🟢 0%
translate/
wasm_kernel
3.82ms 3.81ms ⚪ 0.06% 7.91ms 7.88ms ⚪ -0.65% 🔴 107%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Merging #618 (de0de72) into master (02b4203) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files          83       83           
  Lines        6902     6902           
=======================================
  Hits         5559     5559           
  Misses       1343     1343           
Impacted Files Coverage Δ
crates/wasmi/src/module/builder.rs 99.20% <ø> (ø)
crates/wasmi/src/module/compile/mod.rs 100.00% <ø> (ø)
crates/wasmi/src/module/data.rs 57.14% <ø> (ø)
crates/wasmi/src/module/element.rs 53.57% <ø> (ø)
crates/wasmi/src/module/export.rs 44.00% <ø> (ø)
crates/wasmi/src/module/global.rs 83.33% <ø> (ø)
crates/wasmi/src/module/import.rs 77.77% <ø> (ø)
crates/wasmi/src/module/init_expr.rs 84.61% <ø> (ø)
crates/wasmi/src/module/utils.rs 86.36% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit 004168c into master Jan 17, 2023
@Robbepop Robbepop deleted the rf-rm-module-error branch January 17, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants