Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement bulk-memory Wasm proposal #628

Merged
merged 49 commits into from
Jan 25, 2023
Merged

Implement bulk-memory Wasm proposal #628

merged 49 commits into from
Jan 25, 2023

Commits on Jan 21, 2023

  1. add bulk-memory-operations Wasm spec tests 

    They are currently all failing obviously since bulk-memory has not yet been implemented.
The goal is to implement bulk-memory until all tests pass in this PR.
    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    9bf645e View commit details
    Browse the repository at this point in the history

  2. add bulk_memory flag to Config

    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    8274fc3 View commit details
    Browse the repository at this point in the history

  3. refactor Wasm spec test suite runners

    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    adf388c View commit details
    Browse the repository at this point in the history

  4. refactor define_X_tests macros

    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    7db25a5 View commit details
    Browse the repository at this point in the history

  5. add comment about mutable-global

    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    18834ef View commit details
    Browse the repository at this point in the history

  6. remove ModuleError::Unsupported 

    Those errors are now panics which makes more sense considering the fact that the wasmparser crate already filters out all of those items unless there is a bug. And if there is a bug we should panic instead of properly managing the error.
    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    1331e14 View commit details
    Browse the repository at this point in the history

  7. cleanup after last commit to use panics instead of unsupported error

    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    13e7592 View commit details
    Browse the repository at this point in the history

  8. Update init_expr.rs

    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    12cf30a View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into rf-implement-bulk-memory

    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    c5dd65b View commit details
    Browse the repository at this point in the history

  10. implement initial skeleton for passive data segments

    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    4f05fa9 View commit details
    Browse the repository at this point in the history

  11. export DataSegmentKind from the data module and use it

    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    6f5af22 View commit details
    Browse the repository at this point in the history

  12. refactor data segments minimally

    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    3835643 View commit details
    Browse the repository at this point in the history

  13. add skeleton for passive Wasm element segments

    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    aec8b1e View commit details
    Browse the repository at this point in the history

  14. refactor InitExpr

    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    548d6cb View commit details
    Browse the repository at this point in the history

  15. add InstanceDataSegment to InstanceEntity

    @Robbepop
    Robbepop committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    2c0d4c3 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2023

  1. add data segments to instance and store

    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    fe42f6e View commit details
    Browse the repository at this point in the history

  2. implement memory.init Wasm instruction

    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    aaea98c View commit details
    Browse the repository at this point in the history

  3. replace todo!() with unimplemented!()

    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    1f5a1d5 View commit details
    Browse the repository at this point in the history

  4. fix doc links

    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    6b0854b View commit details
    Browse the repository at this point in the history

  5. implement DataDrop wasmi instruction

    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    24d31c2 View commit details
    Browse the repository at this point in the history

  6. add missing docs

    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    30d5225 View commit details
    Browse the repository at this point in the history

  7. remove commented out line

    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    4035267 View commit details
    Browse the repository at this point in the history

  8. add wasmi memory.fill instruction

    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    5ce1387 View commit details
    Browse the repository at this point in the history

  9. implement wasmi memory.copy instruction

    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    ff2b71d View commit details
    Browse the repository at this point in the history

  10. remove unused APIs

    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    0617781 View commit details
    Browse the repository at this point in the history

  11. fix bug in bulk-memory instructions implemented so far

    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    c1de7ef View commit details
    Browse the repository at this point in the history

  12. move memory query down

    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    5088b4d View commit details
    Browse the repository at this point in the history

  13. fix bug in some bulk-memory instruction impls 

    Now 3 of the 8 bulk-memory Wasm spec tests pass!
    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    45b515d View commit details
    Browse the repository at this point in the history

  14. adjust InitExpr and module::ElementSegment

    @Robbepop
    Robbepop committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    2f95fcd View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. fix bugs

    @Robbepop
    Robbepop committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    716321e View commit details
    Browse the repository at this point in the history

  2. add element segments to the store

    @Robbepop
    Robbepop committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    28d4d5d View commit details
    Browse the repository at this point in the history

  3. implement table.init and elem.drop Wasm instructions

    @Robbepop
    Robbepop committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    1d0c0b3 View commit details
    Browse the repository at this point in the history

  4. update wast from 0.44 to 0.45

    @Robbepop
    Robbepop committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    c13b9a3 View commit details
    Browse the repository at this point in the history

  5. update wast 0.45 -> 0.46

    @Robbepop
    Robbepop committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    076780c View commit details
    Browse the repository at this point in the history

  6. update wast 0.46 -> 0.52

    @Robbepop
    Robbepop committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    377dc1d View commit details
    Browse the repository at this point in the history

  7. implement Wasm table.copy instruction

    @Robbepop
    Robbepop committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    087f5fb View commit details
    Browse the repository at this point in the history

  8. implement user facing Table::copy API

    @Robbepop
    Robbepop committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    127c929 View commit details
    Browse the repository at this point in the history

  9. update Wasm testsuite revision 

    Many tests are failing now. Next steps are to make them pass again.
    @Robbepop
    Robbepop committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    d16827c View commit details
    Browse the repository at this point in the history

  10. cleanup in tests

    @Robbepop
    Robbepop committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    1cad262 View commit details
    Browse the repository at this point in the history

  11. fix typo

    @Robbepop
    Robbepop committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    95e469d View commit details
    Browse the repository at this point in the history

  12. fix Wasm spectest suite test case

    @Robbepop
    Robbepop committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a2b29d4 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. remove some forwarding methods in Store

    @Robbepop
    Robbepop committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    cf047db View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rf-implement-bulk-memory

    @Robbepop
    Robbepop committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    04cc114 View commit details
    Browse the repository at this point in the history

  3. fix remaining bugs

    @Robbepop
    Robbepop committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    a1a5d61 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into rf-implement-bulk-memory

    @Robbepop
    Robbepop committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    49668ce View commit details
    Browse the repository at this point in the history

  5. fix code after merge

    @Robbepop
    Robbepop committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    ea1988c View commit details
    Browse the repository at this point in the history

  6. rename tests

    @Robbepop
    Robbepop committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    da2d5c8 View commit details
    Browse the repository at this point in the history

  7. expect failure for all reference-types related tests

    @Robbepop
    Robbepop committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5e1518d View commit details
    Browse the repository at this point in the history

  8. fix internal doc link

    @Robbepop
    Robbepop committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    e9c25d3 View commit details
    Browse the repository at this point in the history