Use VisitOperator
trait in new FuncTranslator
#645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR carves out a
FuncTranslator
type from the bigFuncBuilder
type.The
FuncBuilder
type now owns aFuncTranslator
as one of its fields.All translation logic now lives inside the
FuncTranslator
type.The
FuncTranslator
properly implements theVisitOperator
trait to translate functions.The
FuncBuilder
has the job to validate any Wasm bytecode before translating it via theVisitOperator
trait.This PR goes one step further into a direction that will allow us to have a well defined interface for
wasmi
multiEngine
backend support.