Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for optional fuel metering #653

Merged
merged 77 commits into from
Feb 11, 2023
Merged

Implement support for optional fuel metering #653

merged 77 commits into from
Feb 11, 2023

Commits on Feb 5, 2023

  1. add TrapCode::OutOfFuel

    @Robbepop
    Robbepop committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    0730fd6 View commit details
    Browse the repository at this point in the history

  2. add support for fuel metering to Config

    @Robbepop
    Robbepop committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    2a59256 View commit details
    Browse the repository at this point in the history

  3. add fuel metering support to Store

    @Robbepop
    Robbepop committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    cfa4a65 View commit details
    Browse the repository at this point in the history

  4. add fuel metering support to Caller

    @Robbepop
    Robbepop committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    77a16f0 View commit details
    Browse the repository at this point in the history

  5. apply rustfmt

    @Robbepop
    Robbepop committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    64d74b3 View commit details
    Browse the repository at this point in the history

  6. add ConsumeFuel wasmi bytecode instruction

    @Robbepop
    Robbepop committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    ccb16bf View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. add convenience method for ConsumeFuel construction

    @Robbepop
    Robbepop committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    c51defb View commit details
    Browse the repository at this point in the history

  2. extend codegen tests to work with metered code

    @Robbepop
    Robbepop committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    bb74cc8 View commit details
    Browse the repository at this point in the history

  3. add Instruction::consumed_fuel method

    @Robbepop
    Robbepop committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    5a3de31 View commit details
    Browse the repository at this point in the history

  4. add initial tests for fuel metering codegen

    @Robbepop
    Robbepop committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    738c338 View commit details
    Browse the repository at this point in the history

  5. apply rustfmt

    @Robbepop
    Robbepop committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    0791743 View commit details
    Browse the repository at this point in the history

  6. respect DropKeep in fuel metering

    @Robbepop
    Robbepop committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    22b31ef View commit details
    Browse the repository at this point in the history

  7. use const for FUEL_PER_KEPT value

    @Robbepop
    Robbepop committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    a697cd6 View commit details
    Browse the repository at this point in the history

  8. apply clippy suggestion

    @Robbepop
    Robbepop committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    aee84f9 View commit details
    Browse the repository at this point in the history

  9. refactor BlockType constructor

    @Robbepop
    Robbepop committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    b1b8977 View commit details
    Browse the repository at this point in the history

  10. add is_fuel_metering_enabled check to FuncTranslator

    @Robbepop
    Robbepop committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    a8ba20d View commit details
    Browse the repository at this point in the history

  11. simplify Store's Fuel implementation 

    This should optimize consume_fuel at the cost of add_fuel. Note that consume_fuel is expected to be called way more often than add_fuel.
    @Robbepop
    Robbepop committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    05ad655 View commit details
    Browse the repository at this point in the history

  12. fix comment

    @Robbepop
    Robbepop committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    e68ce39 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Merge branch 'master' into rf-fuel-metering

    @Robbepop
    Robbepop committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    62ab087 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rf-fuel-metering

    @Robbepop
    Robbepop committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    c4b551e View commit details
    Browse the repository at this point in the history

  3. fix doc link

    @Robbepop
    Robbepop committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    e4a8860 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. remove duped FuncTranslator init in FuncBuilder

    @Robbepop
    Robbepop committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    5318fce View commit details
    Browse the repository at this point in the history

  2. add consume_fuel instr to BlockControlFrame

    @Robbepop
    Robbepop committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    0f0805f View commit details
    Browse the repository at this point in the history

  3. move FuncBuilderAllocations to translator module 

    This is were it belongs. Also renamed it accordingly.
    @Robbepop
    Robbepop committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    300d702 View commit details
    Browse the repository at this point in the history

  4. remove unused imports

    @Robbepop
    Robbepop committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    a3789d3 View commit details
    Browse the repository at this point in the history

  5. remove superflous engine field from FuncTranslator

    @Robbepop
    Robbepop committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    f1d65ea View commit details
    Browse the repository at this point in the history

  6. remove superflous engine parameters

    @Robbepop
    Robbepop committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    a952f15 View commit details
    Browse the repository at this point in the history

  7. apply rustfmt

    @Robbepop
    Robbepop committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    9ec99f2 View commit details
    Browse the repository at this point in the history

  8. refactor FuncTranslator initialization

    @Robbepop
    Robbepop committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    3a65f9a View commit details
    Browse the repository at this point in the history

  9. rename register methods to init methods

    @Robbepop
    Robbepop committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    8057850 View commit details
    Browse the repository at this point in the history

  10. add doc comment

    @Robbepop
    Robbepop committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    32ed222 View commit details
    Browse the repository at this point in the history

  11. add optional consume_fuel field to control frames

    @Robbepop
    Robbepop committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    b67949b View commit details
    Browse the repository at this point in the history

  12. add Instruction::add_fuel convenience method

    @Robbepop
    Robbepop committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    cdf5c10 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Merge branch 'master' into rf-fuel-metering

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    67d1706 View commit details
    Browse the repository at this point in the history

  2. add FuelCosts to Config

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    68c39f5 View commit details
    Browse the repository at this point in the history

  3. add entitiy to FuelCosts and adjust numbers

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    5dea3e3 View commit details
    Browse the repository at this point in the history

  4. add optional consume fuel instruction to function basic block

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    22e789b View commit details
    Browse the repository at this point in the history

  5. apply rustfmt

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    c7c7304 View commit details
    Browse the repository at this point in the history

  6. conditionally add ConsumeFuel instructions to block entries

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    b15dbd6 View commit details
    Browse the repository at this point in the history

  7. fix nostd build

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    dce8d7d View commit details
    Browse the repository at this point in the history

  8. fix internal doc links

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    5116e15 View commit details
    Browse the repository at this point in the history

  9. apply rustfmt

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    ba4a17f View commit details
    Browse the repository at this point in the history

  10. add InstructionBuilder::add_fuel method

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    6eaf9f6 View commit details
    Browse the repository at this point in the history

  11. apply clippy suggestion

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    5dbe355 View commit details
    Browse the repository at this point in the history

  12. fix internal doc link

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9fdbf78 View commit details
    Browse the repository at this point in the history

  13. add FuncTranslator::add_fuel convenience method

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    34c2d00 View commit details
    Browse the repository at this point in the history

  14. add FuncTranslator::fuel_costs getter

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    46ed117 View commit details
    Browse the repository at this point in the history

  15. make Engine::config return Config by reference 

    With the integrated FuelCosts the Config type no longer is as light weight as it was before.
    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    dfa707e View commit details
    Browse the repository at this point in the history

  16. refactor FuncTranslator::fuel_costs getter

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    c8fd0a3 View commit details
    Browse the repository at this point in the history

  17. return FuelCosts without Option

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    7445c6a View commit details
    Browse the repository at this point in the history

  18. use FuncTranslator::fuel_costs in more places

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    01492a7 View commit details
    Browse the repository at this point in the history

  19. remove unused fuel cost code

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    f4e7052 View commit details
    Browse the repository at this point in the history

  20. add fuel costs to memory.size

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    3c3c751 View commit details
    Browse the repository at this point in the history

  21. rename add_fuel to bump_fuel_consumption 

    This should avoid confusion.
    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    1c91428 View commit details
    Browse the repository at this point in the history

  22. properly bump fuel consumption for many instructions

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    46c72c5 View commit details
    Browse the repository at this point in the history

  23. bump fuel consumption in more places

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e15e813 View commit details
    Browse the repository at this point in the history

  24. bump fuel consumption in more places

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e9fc34d View commit details
    Browse the repository at this point in the history

  25. fix compilation

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9163894 View commit details
    Browse the repository at this point in the history

  26. bump fuel consumption in more places

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    6aafefd View commit details
    Browse the repository at this point in the history

  27. bump fuel consumption in even more required places

    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    11d98bf View commit details
    Browse the repository at this point in the history

  28. consume fuel for bulk-memory and table instructions 

    They are treated differently because it is only known during execution how costly the execution of those instructions is going to be.
    @Robbepop
    Robbepop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    2e2849e View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. make existing fuel metering tests base on default fuel costs 

    This way tests won't break when default fuel costs change.
    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    c167e16 View commit details
    Browse the repository at this point in the history

  2. apply clippy suggestion

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    379a820 View commit details
    Browse the repository at this point in the history

  3. add fuel metering test for nested loops

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    650c22d View commit details
    Browse the repository at this point in the history

  4. fix bug in fuel metering codegen for if blocks

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    6623e89 View commit details
    Browse the repository at this point in the history

  5. add fuel metering test for if blocks

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    1d96ace View commit details
    Browse the repository at this point in the history

  6. silence bad clippy lints for test

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    ec6387f View commit details
    Browse the repository at this point in the history

  7. add fuel metering test

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    5d65cba View commit details
    Browse the repository at this point in the history

  8. add more fuel metering tests

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    9922052 View commit details
    Browse the repository at this point in the history

  9. add fuel metering test for globals

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    4631e22 View commit details
    Browse the repository at this point in the history

  10. only charge fuel for memory.grow if successful

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    fbf9da0 View commit details
    Browse the repository at this point in the history

  11. fix internal doc link

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    67b8d05 View commit details
    Browse the repository at this point in the history

  12. add fuel metering tests for calls

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    547ee39 View commit details
    Browse the repository at this point in the history

  13. use $b for local in test

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    499b075 View commit details
    Browse the repository at this point in the history

  14. add fuel metering tests for load and store operations

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    7763747 View commit details
    Browse the repository at this point in the history

  15. apply rustfmt

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    ca1a01e View commit details
    Browse the repository at this point in the history

  16. add simple runtime fuel metering test

    @Robbepop
    Robbepop committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    53cd277 View commit details
    Browse the repository at this point in the history