Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resumable calls bug found in smoldot #671

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Conversation

Robbepop
Copy link
Member

Fixes bug encountered in this GitHub PR: smol-dot/smoldot#18.

@Robbepop Robbepop changed the title Fix resumable funcs Fix resumable calls bug found in smoldot Feb 12, 2023
@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.48ms 1.46ms ⚪ -1.57% 1.24ms 1.20ms 🟢 -3.08% 🟢 -18%
execute/
bare_call_0/typed
1.06ms 1.06ms ⚪ 0.78% 786.39µs 779.91µs ⚪ -0.41% 🟢 -27%
execute/
bare_call_1
1.51ms 1.51ms 🟢 -0.71% 1.39ms 1.39ms 🔴 0.09% 🟢 -7%
execute/
bare_call_16
2.34ms 2.26ms 🟢 -2.80% 4.27ms 4.20ms 🟢 -1.45% 🟡 86%
execute/
bare_call_16/typed
1.60ms 1.57ms ⚪ -1.40% 2.29ms 2.27ms ⚪ -0.85% 🟢 44%
execute/
bare_call_1/typed
1.17ms 1.17ms ⚪ 0.71% 1.19ms 1.22ms 🔴 1.86% 🟢 4%
execute/
bare_call_4
1.65ms 1.66ms 🔴 0.77% 1.97ms 1.92ms 🟢 -2.45% 🟢 16%
execute/
bare_call_4/typed
1.15ms 1.18ms 🔴 1.96% 1.28ms 1.23ms 🟢 -4.28% 🟢 5%
execute/
br_table
1.20ms 1.19ms ⚪ -0.17% 1.39ms 1.40ms ⚪ 0.53% 🟢 18%
execute/
count_until
646.18µs 646.84µs ⚪ 0.17% 2.00ms 1.99ms ⚪ -0.04% 🔴 208%
execute/
factorial_iterative
325.29µs 326.84µs ⚪ 0.41% 918.23µs 912.54µs ⚪ -0.82% 🔴 179%
execute/
factorial_recursive
641.53µs 704.35µs 🔴 9.59% 1.37ms 1.44ms 🔴 5.41% 🔴 104%
execute/
fib_iterative
1.35ms 1.36ms ⚪ 0.47% 5.06ms 5.06ms ⚪ 0.19% 🔴 271%
execute/
fib_recursive
5.82ms 5.83ms ⚪ 0.23% 12.35ms 13.16ms 🔴 6.52% 🔴 126%
execute/
global_bump
974.07µs 1.01ms 🔴 4.03% 2.64ms 2.65ms ⚪ 0.14% 🔴 162%
execute/
global_const
725.57µs 725.88µs ⚪ 0.06% 2.37ms 2.38ms ⚪ 0.31% 🔴 227%
execute/
host_calls
27.42µs 31.20µs 🔴 10.43% 39.00µs 40.19µs 🔴 4.12% 🟢 29%
execute/
memory_fill
1.23ms 1.23ms ⚪ 0.00% 4.26ms 4.24ms ⚪ -0.14% 🔴 244%
execute/
memory_sum
1.19ms 1.19ms ⚪ 0.03% 4.13ms 4.17ms ⚪ 0.93% 🔴 250%
execute/
memory_vec_add
2.42ms 2.42ms ⚪ 0.05% 7.96ms 7.96ms ⚪ -0.01% 🔴 229%
execute/
recursive_is_even
1.15ms 1.14ms ⚪ -0.77% 2.25ms 2.30ms 🔴 2.44% 🔴 101%
execute/
recursive_ok
150.29µs 148.28µs ⚪ -1.09% 316.05µs 320.81µs 🔴 1.58% 🔴 116%
execute/
recursive_scan
178.95µs 180.10µs ⚪ 0.59% 397.27µs 402.92µs 🔴 1.39% 🔴 124%
execute/
recursive_trap
15.02µs 14.77µs 🟢 -1.64% 32.00µs 32.93µs 🔴 2.58% 🔴 123%
execute/
regex_redux
524.90µs 519.56µs ⚪ -0.77% 1.44ms 1.44ms ⚪ -0.19% 🔴 177%
execute/
rev_complement
462.51µs 472.04µs 🔴 1.96% 1.44ms 1.43ms ⚪ -0.86% 🔴 202%
execute/
tiny_keccak
345.42µs 330.57µs 🟢 -3.69% 1.17ms 1.17ms ⚪ -0.21% 🔴 252%
execute/
trunc_f2i
707.65µs 707.77µs ⚪ -0.06% 2.29ms 2.28ms ⚪ -0.16% 🔴 222%
instantiate/
wasm_kernel
63.02µs 64.43µs ⚪ 2.12% 72.50µs 69.80µs 🟢 -2.97% 🟢 8%
translate/
erc1155
233.30µs 233.71µs ⚪ 0.07% 453.75µs 460.74µs 🔴 1.52% 🟡 97%
translate/
erc20
113.61µs 113.69µs ⚪ 0.10% 217.34µs 223.90µs 🔴 2.88% 🟡 97%
translate/
erc721
161.36µs 160.60µs ⚪ -0.48% 317.10µs 325.00µs 🔴 2.67% 🔴 102%
translate/
spidermonkey
0.00ns 0.00ns ⚪ -0.32% 0.00ns 0.00ns ⚪ 0.62% 🟢 0%
translate/
wasm_kernel
4.05ms 4.02ms ⚪ -0.84% 8.23ms 8.33ms 🔴 1.41% 🔴 107%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Merging #671 (3ca4074) into master (40182b6) will increase coverage by 0.06%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   81.31%   81.37%   +0.06%     
==========================================
  Files         100      100              
  Lines        8358     8386      +28     
==========================================
+ Hits         6796     6824      +28     
  Misses       1562     1562              
Impacted Files Coverage Δ
crates/wasmi/tests/e2e/v1/resumable_call.rs 88.67% <86.36%> (-0.61%) ⬇️
crates/wasmi/src/engine/stack/mod.rs 83.33% <100.00%> (+1.28%) ⬆️
crates/wasmi/src/instance/mod.rs 71.42% <0.00%> (+4.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit 5ef26a7 into master Feb 12, 2023
@Robbepop Robbepop deleted the rf-fix-resumable-funcs-bug branch February 12, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants