Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Linker for preparation of Linker::func_{wrap,new} methods #681

Merged
merged 15 commits into from
Feb 15, 2023
Merged

Refactor Linker for preparation of Linker::func_{wrap,new} methods #681

merged 15 commits into from
Feb 15, 2023

Commits on Feb 15, 2023

  1. make FuncEntitty use Engine instead of Store to alloc

    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    826a938 View commit details
    Browse the repository at this point in the history

  2. return instance by shared reference instead of by value

    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    dc2fb5d View commit details
    Browse the repository at this point in the history

  3. make Linker::resolve method private 

    This method does also not exist in the Wasmtime Linker API.
    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    c5fbcfc View commit details
    Browse the repository at this point in the history

  4. add Engine::same 

    From the Wasmtime API.
    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    e35a688 View commit details
    Browse the repository at this point in the history

  5. add Engine to Linker 

    This is going to be important for planned Linker::func_new and Linker::func_wrap methods.
    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    d42a79d View commit details
    Browse the repository at this point in the history

  6. apply rustfmt

    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    ee127bb View commit details
    Browse the repository at this point in the history

  7. assert that Linker and Store engines are the same 

    This assertion revealed some bugs in our own testsuite.
    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    a9483d5 View commit details
    Browse the repository at this point in the history

  8. add Definition to Linker 

    This will allow us to define Linker-owned host functions later. Most part of the commit was to properly implement Debug for Linker.
    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    0db1649 View commit details
    Browse the repository at this point in the history

  9. apply clippy suggestions 

    Also rename resolve to get.
    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    93f98dc View commit details
    Browse the repository at this point in the history

  10. apply clippy suggestions

    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    a71ffc3 View commit details
    Browse the repository at this point in the history

  11. temporarily fix internal doc links in Linker

    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    d226d6a View commit details
    Browse the repository at this point in the history

  12. apply more clippy suggestions

    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    0e04cb7 View commit details
    Browse the repository at this point in the history

  13. fix benchmarks

    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    b8875a3 View commit details
    Browse the repository at this point in the history

  14. fix more benchmarks

    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    b44e2fe View commit details
    Browse the repository at this point in the history

  15. fix another benchmark test

    @Robbepop
    Robbepop committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    c26b680 View commit details
    Browse the repository at this point in the history