Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use StoreContextMut in Engine code #685

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Use StoreContextMut in Engine code #685

merged 1 commit into from
Feb 20, 2023

Conversation

Robbepop
Copy link
Member

No description provided.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.44ms 1.49ms 🔴 3.19% 1.28ms 1.24ms 🔴 -2.74% 🟢 -16%
execute/
bare_call_0/typed
1.05ms 1.17ms 🔴 10.30% 896.86µs 957.29µs 🔴 6.81% 🟢 -18%
execute/
bare_call_1
1.49ms 1.53ms 🔴 3.10% 1.53ms 1.46ms 🟢 -5.00% 🟢 -5%
execute/
bare_call_16
2.37ms 2.36ms ⚪ 0.17% 4.38ms 4.33ms 🟢 -1.12% 🟡 83%
execute/
bare_call_16/typed
1.59ms 1.59ms ⚪ 0.14% 2.39ms 2.34ms 🟢 -2.48% 🟢 47%
execute/
bare_call_1/typed
1.14ms 1.17ms 🔴 2.68% 1.31ms 1.27ms 🟢 -3.15% 🟢 8%
execute/
bare_call_4
1.61ms 1.61ms 🔴 0.50% 2.05ms 1.96ms 🟢 -4.29% 🟢 22%
execute/
bare_call_4/typed
1.15ms 1.22ms 🔴 6.16% 1.48ms 1.39ms 🟢 -6.13% 🟢 14%
execute/
br_table
1.22ms 1.22ms ⚪ 1.08% 1.48ms 1.49ms ⚪ 0.76% 🟢 23%
execute/
count_until
652.24µs 652.49µs ⚪ 0.09% 2.27ms 2.27ms ⚪ 0.02% 🔴 247%
execute/
factorial_iterative
317.69µs 318.32µs ⚪ 0.32% 942.05µs 947.74µs ⚪ 0.57% 🔴 198%
execute/
factorial_recursive
659.58µs 656.43µs ⚪ -0.56% 1.31ms 1.31ms ⚪ 0.02% 🟡 100%
execute/
fib_iterative
1.41ms 1.41ms ⚪ -0.13% 5.14ms 5.15ms ⚪ 0.00% 🔴 266%
execute/
fib_recursive
5.86ms 5.94ms 🔴 1.23% 11.36ms 11.26ms ⚪ -0.93% 🟡 90%
execute/
global_bump
1.03ms 1.03ms ⚪ 0.21% 2.53ms 2.53ms ⚪ -0.49% 🔴 145%
execute/
global_const
686.90µs 685.73µs ⚪ -0.09% 2.61ms 2.57ms ⚪ -2.06% 🔴 274%
execute/
host_calls
27.94µs 28.06µs ⚪ 5.98% 42.77µs 42.31µs ⚪ -0.97% 🟡 51%
execute/
memory_fill
1.19ms 1.19ms ⚪ -0.02% 4.19ms 4.20ms ⚪ 0.09% 🔴 252%
execute/
memory_sum
1.19ms 1.17ms ⚪ -1.00% 4.14ms 4.14ms ⚪ 0.05% 🔴 252%
execute/
memory_vec_add
2.39ms 2.40ms ⚪ 0.12% 7.69ms 7.69ms ⚪ 0.03% 🔴 221%
execute/
recursive_is_even
1.18ms 1.15ms 🟢 -2.21% 2.35ms 2.30ms 🟢 -2.08% 🟡 99%
execute/
recursive_ok
151.56µs 152.44µs ⚪ 0.42% 310.49µs 306.74µs 🟢 -1.45% 🔴 101%
execute/
recursive_scan
186.16µs 186.38µs ⚪ 0.20% 377.71µs 375.00µs ⚪ -0.73% 🔴 101%
execute/
recursive_trap
15.02µs 14.96µs ⚪ -0.33% 32.07µs 31.03µs 🟢 -3.23% 🔴 107%
execute/
regex_redux
536.57µs 543.98µs ⚪ 1.26% 1.37ms 1.38ms ⚪ 0.46% 🔴 153%
execute/
rev_complement
463.45µs 462.06µs ⚪ -0.22% 1.42ms 1.42ms ⚪ 0.52% 🔴 207%
execute/
tiny_keccak
325.14µs 325.00µs ⚪ 0.08% 1.14ms 1.14ms ⚪ 0.08% 🔴 252%
execute/
trunc_f2i
690.90µs 721.24µs 🔴 4.41% 2.16ms 2.13ms 🟢 -1.62% 🔴 195%
instantiate/
wasm_kernel
63.62µs 64.10µs ⚪ 1.81% 71.52µs 71.31µs ⚪ -1.79% 🟢 11%
translate/
erc1155
236.80µs 234.18µs ⚪ -0.88% 454.00µs 456.98µs ⚪ 0.59% 🟡 95%
translate/
erc20
114.66µs 114.28µs ⚪ -0.14% 217.28µs 219.94µs ⚪ 1.07% 🟡 92%
translate/
erc721
161.40µs 161.85µs ⚪ 0.49% 318.02µs 323.52µs ⚪ 2.17% 🟡 100%
translate/
spidermonkey
0.00ns 0.00ns ⚪ 0.36% 0.00ns 0.00ns ⚪ 0.84% 🟢 0%
translate/
wasm_kernel
4.12ms 4.11ms ⚪ 0.44% 8.33ms 8.38ms ⚪ 0.55% 🔴 104%

Link to pipeline

@Robbepop Robbepop merged commit 2f4d714 into master Feb 20, 2023
@Robbepop Robbepop deleted the rf-cleanup-engine branch February 20, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants