Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experimental] Optimize memory consumption (take 2) #718

Merged
merged 52 commits into from
May 23, 2023
Merged

[experimental] Optimize memory consumption (take 2) #718

merged 52 commits into from
May 23, 2023

Commits on May 16, 2023

  1. add intx dependency

    @Robbepop
    Robbepop committed May 16, 2023
    Configuration menu
    Copy the full SHA
    e67b89d View commit details
    Browse the repository at this point in the history

  2. add new translation error kinds

    @Robbepop
    Robbepop committed May 16, 2023
    Configuration menu
    Copy the full SHA
    e0e45b6 View commit details
    Browse the repository at this point in the history

  3. re-export TranslationErrorInner

    @Robbepop
    Robbepop committed May 16, 2023
    Configuration menu
    Copy the full SHA
    41aa2aa View commit details
    Browse the repository at this point in the history

  4. make bytecode::FuncIdx use U24 internally

    @Robbepop
    Robbepop committed May 16, 2023
    Configuration menu
    Copy the full SHA
    0f4ba7f View commit details
    Browse the repository at this point in the history

  5. rename FuncIdx::into_inner to to_u32

    @Robbepop
    Robbepop committed May 16, 2023
    Configuration menu
    Copy the full SHA
    add28ce View commit details
    Browse the repository at this point in the history

  6. fix tests after FuncIdx refactoring

    @Robbepop
    Robbepop committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ebb02d4 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. refactor bytecode::TableIdx to use 3 bytes only

    @Robbepop
    Robbepop committed May 17, 2023
    Configuration menu
    Copy the full SHA
    138b8ed View commit details
    Browse the repository at this point in the history

  2. correct error

    @Robbepop
    Robbepop committed May 17, 2023
    Configuration menu
    Copy the full SHA
    fc75c00 View commit details
    Browse the repository at this point in the history

  3. make SignatureIdx use 3 bytes only

    @Robbepop
    Robbepop committed May 17, 2023
    Configuration menu
    Copy the full SHA
    12d0a19 View commit details
    Browse the repository at this point in the history

  4. make LocalDepth use 3 bytes only

    @Robbepop
    Robbepop committed May 17, 2023
    Configuration menu
    Copy the full SHA
    891ffe0 View commit details
    Browse the repository at this point in the history

  5. make GlobalIdx use 3 bytes only

    @Robbepop
    Robbepop committed May 17, 2023
    Configuration menu
    Copy the full SHA
    e4ee65c View commit details
    Browse the repository at this point in the history

  6. rename GlobalIdx::into_inner -> to_u32

    @Robbepop
    Robbepop committed May 17, 2023
    Configuration menu
    Copy the full SHA
    659fc03 View commit details
    Browse the repository at this point in the history

  7. make data and element segment indices 24-bit sized

    @Robbepop
    Robbepop committed May 17, 2023
    Configuration menu
    Copy the full SHA
    04c4d38 View commit details
    Browse the repository at this point in the history

  8. add missing commits (oups)

    @Robbepop
    Robbepop committed May 17, 2023
    Configuration menu
    Copy the full SHA
    35a2fb0 View commit details
    Browse the repository at this point in the history

  9. move DropKeep def to the bottom of the file

    @Robbepop
    Robbepop committed May 17, 2023
    Configuration menu
    Copy the full SHA
    dc5906e View commit details
    Browse the repository at this point in the history

  10. update docs

    @Robbepop
    Robbepop committed May 17, 2023
    Configuration menu
    Copy the full SHA
    2847a4d View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. make BranchOffset use I24 instead of i32 internally

    @Robbepop
    Robbepop committed May 18, 2023
    Configuration menu
    Copy the full SHA
    a78f2da View commit details
    Browse the repository at this point in the history

  2. apply clippy suggestions

    @Robbepop
    Robbepop committed May 18, 2023
    Configuration menu
    Copy the full SHA
    818146a View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. improve Debug impl for FuncType

    @Robbepop
    Robbepop committed May 19, 2023
    Configuration menu
    Copy the full SHA
    1b703c1 View commit details
    Browse the repository at this point in the history

  2. make DropKeep use only 3 bytes 

    This optimization makes both, drop and keep, values use only 12 bits each, restricting their range of valid numbers to just 0-4095. While low, these numbers should suffice for practical use cases. If practical use cases arise that exceed these limitations we might think about new or better encodings.
    @Robbepop
    Robbepop committed May 19, 2023
    Configuration menu
    Copy the full SHA
    37371f6 View commit details
    Browse the repository at this point in the history

  3. make br_table targets use U24 internally

    @Robbepop
    Robbepop committed May 19, 2023
    Configuration menu
    Copy the full SHA
    fb03bb7 View commit details
    Browse the repository at this point in the history

  4. make Local{Get,Set,Tee} tuple struct variants

    @Robbepop
    Robbepop committed May 19, 2023
    Configuration menu
    Copy the full SHA
    cb78426 View commit details
    Browse the repository at this point in the history

  5. remove dbg println

    @Robbepop
    Robbepop committed May 19, 2023
    Configuration menu
    Copy the full SHA
    3f2d183 View commit details
    Browse the repository at this point in the history

  6. fix minor bug

    @Robbepop
    Robbepop committed May 19, 2023
    Configuration menu
    Copy the full SHA
    658773b View commit details
    Browse the repository at this point in the history

  7. fix bug in DropKeep with big endian systems

    @Robbepop
    Robbepop committed May 19, 2023
    Configuration menu
    Copy the full SHA
    e6f1fa1 View commit details
    Browse the repository at this point in the history

  8. fix internal doc link

    @Robbepop
    Robbepop committed May 19, 2023
    Configuration menu
    Copy the full SHA
    14f2c4f View commit details
    Browse the repository at this point in the history

  9. make ConsumeFuel instr use 24-bit encoding

    @Robbepop
    Robbepop committed May 19, 2023
    Configuration menu
    Copy the full SHA
    b28058e View commit details
    Browse the repository at this point in the history

  10. remove superflous error kind

    @Robbepop
    Robbepop committed May 19, 2023
    Configuration menu
    Copy the full SHA
    03959e3 View commit details
    Browse the repository at this point in the history

  11. extend wasmi bytecode utils tests

    @Robbepop
    Robbepop committed May 19, 2023
    Configuration menu
    Copy the full SHA
    e200196 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. convert more Instruction variants into tuple structs 

    This makes more sense with the planned introduction of InstructionWord as a base unit of instruction encoding.
    @Robbepop
    Robbepop committed May 20, 2023
    Configuration menu
    Copy the full SHA
    4445181 View commit details
    Browse the repository at this point in the history

  2. apply new encoding to wasmi branch instructions

    @Robbepop
    Robbepop committed May 20, 2023
    Configuration menu
    Copy the full SHA
    8267923 View commit details
    Browse the repository at this point in the history

  3. fix and improve internal docs

    @Robbepop
    Robbepop committed May 20, 2023
    Configuration menu
    Copy the full SHA
    216e325 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. make ReturnCall instruction use 3 bytes only

    @Robbepop
    Robbepop committed May 22, 2023
    Configuration menu
    Copy the full SHA
    6753dbf View commit details
    Browse the repository at this point in the history

  2. make ReturnCallIndirect use only 3 bytes for encoding

    @Robbepop
    Robbepop committed May 22, 2023
    Configuration menu
    Copy the full SHA
    81d3f9e View commit details
    Browse the repository at this point in the history

  3. make CallIndirect use 3 bytes encoding

    @Robbepop
    Robbepop committed May 22, 2023
    Configuration menu
    Copy the full SHA
    b0fa320 View commit details
    Browse the repository at this point in the history

  4. make TableCopy encode in 3 bytes only

    @Robbepop
    Robbepop committed May 22, 2023
    Configuration menu
    Copy the full SHA
    5b57b91 View commit details
    Browse the repository at this point in the history

  5. make TableInit use 3 byte encoding

    @Robbepop
    Robbepop committed May 22, 2023
    Configuration menu
    Copy the full SHA
    91abfaa View commit details
    Browse the repository at this point in the history

  6. fix internal docs

    @Robbepop
    Robbepop committed May 22, 2023
    Configuration menu
    Copy the full SHA
    98c8ac9 View commit details
    Browse the repository at this point in the history

  7. add ConstPool type 

    We are going to need this for the new encoding of memory load and store as well as constant value instructions.
    @Robbepop
    Robbepop committed May 22, 2023
    Configuration menu
    Copy the full SHA
    235c62f View commit details
    Browse the repository at this point in the history

  8. introduce I{32,64}Const24 instructions 

    These are more (space-)efficient alternatives to more general constant value instructions for small integer values.
    @Robbepop
    Robbepop committed May 22, 2023
    Configuration menu
    Copy the full SHA
    ce12a7c View commit details
    Browse the repository at this point in the history

  9. introduce new ConstRef instruction 

    This new ConstRef instruction replaces the old Const instruction. The advantage of ConstRef is that it is possible to encode it in 3 bytes. This is a trade off since it is probably slower at execution time. To circumvent unnecessary slowdowns in common cases we introduced I32Const24 and I64Const24 instructions earlier.
    @Robbepop
    Robbepop committed May 22, 2023
    Configuration menu
    Copy the full SHA
    35df49c View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. introduce Const32 instruction

    @Robbepop
    Robbepop committed May 23, 2023
    Configuration menu
    Copy the full SHA
    ed202c3 View commit details
    Browse the repository at this point in the history

  2. change I64Const24 -> I64Const32

    @Robbepop
    Robbepop committed May 23, 2023
    Configuration menu
    Copy the full SHA
    2d1f579 View commit details
    Browse the repository at this point in the history

  3. make bytecode utils base on u32 and i32 again

    @Robbepop
    Robbepop committed May 23, 2023
    Configuration menu
    Copy the full SHA
    5c8a52e View commit details
    Browse the repository at this point in the history

  4. remove unused translation error kinds

    @Robbepop
    Robbepop committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d46928c View commit details
    Browse the repository at this point in the history

  5. rename Offset to AddressOffset

    @Robbepop
    Robbepop committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8332a07 View commit details
    Browse the repository at this point in the history

  6. make BranchOffset encoding 4 bytes

    @Robbepop
    Robbepop committed May 23, 2023
    Configuration menu
    Copy the full SHA
    28920b8 View commit details
    Browse the repository at this point in the history

  7. make BranchTableTargets encoding 4 bytes

    @Robbepop
    Robbepop committed May 23, 2023
    Configuration menu
    Copy the full SHA
    65061a4 View commit details
    Browse the repository at this point in the history

  8. make BlockFuel encoding 4 bytes

    @Robbepop
    Robbepop committed May 23, 2023
    Configuration menu
    Copy the full SHA
    142d5dc View commit details
    Browse the repository at this point in the history

  9. make DropKeep encoding 4 bytes

    @Robbepop
    Robbepop committed May 23, 2023
    Configuration menu
    Copy the full SHA
    03222e9 View commit details
    Browse the repository at this point in the history

  10. implement non-adjusting branches

    @Robbepop
    Robbepop committed May 23, 2023
    Configuration menu
    Copy the full SHA
    4b3df45 View commit details
    Browse the repository at this point in the history

  11. apply clippy suggestions

    @Robbepop
    Robbepop committed May 23, 2023
    Configuration menu
    Copy the full SHA
    3b83ca1 View commit details
    Browse the repository at this point in the history