-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #735: copy paste typo #741
Conversation
BENCHMARKS
|
Thanks a lot @behkod for this fix! Can you please fix the formatting (look into CI logs) so that we can merge this PR? :) |
Oops, happened coz of automatic on-save formatting. just updated it. Thanks for quick review. |
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
==========================================
+ Coverage 79.25% 79.40% +0.15%
==========================================
Files 104 104
Lines 9046 9054 +8
==========================================
+ Hits 7169 7189 +20
+ Misses 1877 1865 -12
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@Robbepop AFA concerns related to issue 735 & this pr, checks are passed (at least I guess so), but Clippy raises a warning on a file I didn't touch. Do you need me to change that as well or we are good to go? |
The |
Thanks for taking care fast & of course for the explanation. |
No description provided.