Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #735: copy paste typo #741

Merged
merged 2 commits into from
Jul 26, 2023
Merged

fixes #735: copy paste typo #741

merged 2 commits into from
Jul 26, 2023

Conversation

behkod
Copy link
Contributor

@behkod behkod commented Jul 25, 2023

No description provided.

@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Jul 25, 2023

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.53ms 1.54ms ⚪ 0.64% 1.03ms 1.04ms ⚪ 0.49% 🟢 -33%
execute/
bare_call_0/typed
1.14ms 1.14ms ⚪ -0.08% 661.73µs 657.59µs ⚪ -0.60% 🟢 -42%
execute/
bare_call_1
1.60ms 1.60ms ⚪ 0.05% 1.20ms 1.21ms 🔴 1.09% 🟢 -24%
execute/
bare_call_16
2.60ms 2.57ms ⚪ -1.26% 3.55ms 3.51ms 🟢 -1.24% 🟢 37%
execute/
bare_call_16/typed
1.57ms 1.56ms ⚪ -1.09% 1.82ms 1.77ms 🟢 -3.02% 🟢 14%
execute/
bare_call_1/typed
1.25ms 1.25ms ⚪ 1.09% 982.00µs 1.00ms 🔴 2.13% 🟢 -20%
execute/
bare_call_4
1.78ms 1.78ms ⚪ -0.40% 1.66ms 1.65ms 🔴 -1.03% 🟢 -7%
execute/
bare_call_4/typed
1.24ms 1.24ms ⚪ 0.10% 941.76µs 963.84µs 🔴 2.27% 🟢 -22%
execute/
br_table
1.36ms 1.35ms ⚪ -1.00% 1.19ms 1.20ms ⚪ 1.19% 🟢 -11%
execute/
count_until
624.97µs 583.80µs 🟢 -7.12% 1.30ms 1.35ms 🔴 3.54% 🔴 131%
execute/
factorial_iterative
319.29µs 319.65µs ⚪ -0.20% 669.44µs 673.62µs ⚪ 0.63% 🔴 111%
execute/
factorial_recursive
514.88µs 512.68µs ⚪ -0.43% 868.90µs 895.54µs 🔴 3.06% 🟡 75%
execute/
fibonacci_iter
1.40ms 1.39ms ⚪ -0.84% 3.24ms 3.23ms ⚪ -0.61% 🔴 132%
execute/
fibonacci_rec
4.46ms 4.44ms ⚪ -0.56% 7.57ms 7.52ms ⚪ -0.66% 🟡 70%
execute/
fibonacci_tail
974.42µs 975.89µs ⚪ 0.36% 1.88ms 1.90ms ⚪ 1.09% 🟡 94%
execute/
global_bump
768.72µs 745.85µs 🟢 -2.65% 1.67ms 1.72ms 🔴 3.25% 🔴 131%
execute/
global_const
665.16µs 682.40µs 🔴 2.64% 1.68ms 1.68ms ⚪ -0.33% 🔴 146%
execute/
host_calls
36.57µs 39.15µs 🔴 5.75% 39.56µs 39.12µs ⚪ -0.90% 🟢 -0%
execute/
memory_fill
1.15ms 1.17ms ⚪ 1.07% 2.62ms 2.62ms ⚪ 0.03% 🔴 125%
execute/
memory_sum
1.13ms 1.14ms ⚪ 0.37% 2.42ms 2.49ms 🔴 2.50% 🔴 119%
execute/
memory_vec_add
2.32ms 2.40ms ⚪ 2.97% 5.23ms 5.25ms ⚪ 0.35% 🔴 119%
execute/
recursive_is_even
715.53µs 710.27µs ⚪ -0.76% 1.28ms 1.30ms 🔴 2.04% 🟡 83%
execute/
recursive_ok
105.37µs 103.89µs ⚪ -0.96% 187.06µs 190.66µs 🔴 1.53% 🟡 84%
execute/
recursive_scan
140.48µs 140.39µs ⚪ -0.06% 244.77µs 240.63µs 🟢 -1.70% 🟡 71%
execute/
recursive_trap
10.36µs 10.17µs 🟢 -1.67% 18.74µs 19.35µs 🔴 3.13% 🟡 90%
execute/
regex_redux
456.79µs 458.09µs ⚪ 0.46% 921.01µs 931.19µs ⚪ 1.00% 🔴 103%
execute/
rev_complement
431.21µs 421.87µs 🟢 -1.83% 925.50µs 941.45µs 🔴 1.68% 🔴 123%
execute/
tiny_keccak
319.55µs 329.40µs 🔴 2.85% 804.39µs 803.19µs ⚪ -0.14% 🔴 144%
execute/
trunc_f2i
734.36µs 751.90µs 🔴 2.36% 1.79ms 1.78ms ⚪ -0.94% 🔴 136%
instantiate/
wasm_kernel
57.78µs 56.64µs ⚪ -1.35% 54.16µs 58.82µs 🔴 4.91% 🟢 4%
translate/
erc1155
185.76µs 190.04µs 🔴 2.68% 315.44µs 311.27µs 🟢 -1.57% 🟡 64%
translate/
erc20
92.62µs 92.75µs ⚪ -0.02% 154.74µs 153.65µs ⚪ -0.63% 🟡 66%
translate/
erc721
130.50µs 131.03µs ⚪ 0.56% 220.72µs 219.13µs ⚪ -0.66% 🟡 67%
translate/
spidermonkey
57.80ms 58.19ms ⚪ 0.91% 0.00ns 0.00ns ⚪ 0.35% 🟢 -100%
translate/
wasm_kernel
4.01ms 4.02ms ⚪ 0.24% 5.84ms 5.87ms ⚪ 0.31% 🟢 46%

Link to pipeline

@Robbepop
Copy link
Member

Thanks a lot @behkod for this fix! Can you please fix the formatting (look into CI logs) so that we can merge this PR? :)

@behkod
Copy link
Contributor Author

behkod commented Jul 26, 2023

Thanks a lot @behkod for this fix! Can you please fix the formatting (look into CI logs) so that we can merge this PR? :)

Oops, happened coz of automatic on-save formatting. just updated it. Thanks for quick review.

@codecov-commenter
Copy link

Codecov Report

Merging #741 (5dffd9e) into master (4860ecc) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
+ Coverage   79.25%   79.40%   +0.15%     
==========================================
  Files         104      104              
  Lines        9046     9054       +8     
==========================================
+ Hits         7169     7189      +20     
+ Misses       1877     1865      -12     
Files Changed Coverage Δ
crates/wasmi/src/module/mod.rs 74.10% <100.00%> (ø)

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@behkod
Copy link
Contributor Author

behkod commented Jul 26, 2023

@Robbepop AFA concerns related to issue 735 & this pr, checks are passed (at least I guess so), but Clippy raises a warning on a file I didn't touch. Do you need me to change that as well or we are good to go?

@Robbepop
Copy link
Member

The clippy job fails not because of this PR but because master is outdated with respect to Rust. Another PR is needed. This is good to go. Thanks a lot @behkod for the fix! :)

@Robbepop Robbepop merged commit e5fdb7f into wasmi-labs:master Jul 26, 2023
11 of 12 checks passed
@behkod
Copy link
Contributor Author

behkod commented Jul 26, 2023

Thanks for taking care fast & of course for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants