Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce WasmTranslator trait #828

Merged
merged 4 commits into from
Dec 3, 2023
Merged

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Dec 3, 2023

This is later going to be used to implement #817 and others.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
br_table
1.51ms 1.49ms ⚪ -1.25% 1.26ms 1.28ms 🔴 1.67% 🟢 -14%
execute/
call/host/1
46.72µs 44.85µs 🟢 -3.52% 65.39µs 64.22µs 🟢 -1.81% 🟢 43%
execute/
call/rec
168.33µs 165.81µs ⚪ -1.27% 357.42µs 357.19µs ⚪ -0.06% 🔴 115%
execute/
count_until
6.66ms 7.47ms 🔴 12.43% 7.49ms 7.51ms ⚪ 0.28% 🟢 1%
execute/
divrem
6.22ms 6.27ms ⚪ 0.81% 6.96ms 6.97ms ⚪ 0.02% 🟢 11%
execute/
factorial/iter
232.22µs 255.11µs 🔴 10.05% 314.77µs 315.84µs ⚪ 0.16% 🟢 24%
execute/
factorial/rec
683.35µs 696.37µs 🔴 2.02% 1.28ms 1.26ms 🟢 -2.03% 🟡 80%
execute/
fibonacci/iter
1.29ms 1.27ms ⚪ -1.41% 1.27ms 1.26ms ⚪ -0.33% 🟢 -0%
execute/
fibonacci/rec
6.07ms 6.05ms ⚪ -0.37% 12.93ms 13.11ms 🔴 1.41% 🔴 117%
execute/
fibonacci/tail
1.50ms 1.57ms 🔴 4.74% 3.55ms 3.92ms 🔴 10.42% 🔴 150%
execute/
fuse
7.35ms 7.88ms 🔴 7.19% 11.59ms 11.41ms 🟢 -1.56% 🟢 45%
execute/
global/bump
1.32ms 1.32ms ⚪ 0.32% 1.54ms 1.54ms ⚪ 0.04% 🟢 16%
execute/
global/get_const
712.76µs 732.93µs 🔴 3.18% 750.82µs 750.17µs ⚪ -0.11% 🟢 2%
execute/
is_even/rec
1.07ms 1.08ms ⚪ 0.70% 2.29ms 2.26ms ⚪ -1.38% 🔴 109%
execute/
memory/fill_bytes
1.08ms 1.09ms ⚪ 1.11% 1.31ms 1.32ms ⚪ 0.35% 🟢 21%
execute/
memory/sum_bytes
1.10ms 1.04ms 🟢 -5.06% 1.23ms 1.25ms 🔴 1.83% 🟢 20%
execute/
memory/vec_add
2.97ms 2.95ms ⚪ -1.07% 3.61ms 3.63ms ⚪ 0.32% 🟢 23%
execute/
recursive_scan
187.30µs 186.45µs ⚪ -0.54% 389.70µs 387.26µs ⚪ -0.59% 🔴 108%
execute/
recursive_trap
15.36µs 15.29µs ⚪ -0.59% 35.54µs 35.10µs ⚪ -1.17% 🔴 130%
execute/
regex_redux
589.60µs 593.58µs ⚪ 0.73% 1.05ms 1.06ms ⚪ 0.42% 🟡 78%
execute/
rev_complement
444.69µs 444.30µs ⚪ 0.01% 642.51µs 638.19µs ⚪ -0.57% 🟢 44%
execute/
tiny_keccak
357.54µs 370.52µs ⚪ 0.56% 380.54µs 378.68µs ⚪ -0.52% 🟢 2%
execute/
trunc_f2i
615.88µs 615.02µs ⚪ -0.28% 952.51µs 961.35µs ⚪ 0.92% 🟡 56%
instantiate/
wasm_kernel
54.77µs 55.00µs ⚪ 1.24% 54.48µs 57.44µs 🔴 4.69% 🟢 4%
overhead/
call/typed/0
1.19ms 1.21ms ⚪ 2.15% 783.83µs 756.89µs 🟢 -3.42% 🟢 -37%
overhead/
call/typed/16
1.59ms 1.60ms ⚪ 0.33% 1.96ms 1.89ms 🟢 -3.65% 🟢 18%
overhead/
call/untyped/0
1.62ms 1.60ms ⚪ -1.21% 1.22ms 1.22ms ⚪ 0.41% 🟢 -24%
overhead/
call/untyped/16
2.46ms 2.66ms 🔴 7.75% 3.91ms 3.83ms 🟢 -2.08% 🟢 44%
translate/
bz2/default
1.38ms 1.39ms ⚪ 1.09% 2.56ms 2.49ms 🟢 -2.91% 🟡 78%
translate/
bz2/fuel
1.42ms 1.44ms ⚪ 1.41% 2.70ms 2.64ms 🟢 -2.16% 🟡 83%
translate/
erc1155/default
280.27µs 282.90µs ⚪ 0.85% 492.52µs 483.67µs ⚪ -1.58% 🟡 71%
translate/
erc1155/fuel
301.68µs 303.25µs ⚪ 0.35% 518.18µs 514.59µs ⚪ -0.67% 🟡 70%
translate/
erc20/default
135.25µs 136.84µs ⚪ 1.08% 232.14µs 231.26µs ⚪ -0.46% 🟡 69%
translate/
erc20/fuel
143.87µs 144.31µs ⚪ 0.31% 242.60µs 242.15µs ⚪ -0.26% 🟡 68%
translate/
erc721/default
191.69µs 194.38µs ⚪ 1.21% 336.78µs 334.13µs ⚪ -0.86% 🟡 72%
translate/
erc721/fuel
202.65µs 203.37µs ⚪ 0.49% 350.72µs 352.93µs ⚪ 0.48% 🟡 74%
translate/
pulldown_cmark/default
3.72ms 3.79ms 🔴 2.13% 6.65ms 6.51ms 🟢 -2.19% 🟡 72%
translate/
pulldown_cmark/fuel
3.82ms 3.89ms 🔴 2.34% 6.93ms 6.84ms 🟢 -1.28% 🟡 76%
translate/
spidermonkey/default
0.00ns 0.00ns ⚪ 0.56% 0.00ns 0.00ns 🟢 -2.82% 🟢 0%
translate/
spidermonkey/fuel
0.00ns 0.00ns 🔴 1.41% 0.00ns 0.00ns 🟢 -1.91% 🟢 0%
translate/
wasm_kernel/default
4.98ms 4.99ms ⚪ 0.20% 8.92ms 8.75ms 🟢 -2.04% 🟡 75%
translate/
wasm_kernel/fuel
5.13ms 5.15ms ⚪ 0.36% 9.28ms 9.18ms ⚪ -1.07% 🟡 78%

Link to pipeline

@Robbepop Robbepop merged commit 5d4ea7b into master Dec 3, 2023
18 checks passed
@Robbepop Robbepop deleted the rf-refactor-wasm-translator branch December 3, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants