Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI jobs use dtolnay/rust-toolchain instead of actions-rs #842

Merged
merged 9 commits into from
Dec 8, 2023

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Dec 8, 2023

The problem is that GitHub Actions actions-rs got archived and is no longer expected to be maintained.

@Robbepop Robbepop changed the title Make CI jobs use dtolnay/rust-toolchain instead of deprecated actions-rs Make CI jobs use dtolnay/rust-toolchain instead of actions-rs Dec 8, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac84fe) 81.06% compared to head (7488038) 81.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #842   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files         257      257           
  Lines       22597    22597           
=======================================
  Hits        18318    18318           
  Misses       4279     4279           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
br_table
1.48ms 1.45ms 🟢 -2.11% 1.31ms 1.31ms ⚪ 0.41% 🟢 -10%
execute/
call/host/1
45.61µs 46.04µs ⚪ 0.96% 65.06µs 70.90µs 🔴 8.97% 🟡 54%
execute/
call/rec
167.63µs 168.20µs ⚪ 0.34% 344.89µs 346.23µs ⚪ 0.39% 🔴 106%
execute/
count_until
6.66ms 6.68ms ⚪ 0.29% 7.51ms 7.51ms ⚪ 0.04% 🟢 12%
execute/
divrem
6.22ms 6.22ms ⚪ 0.15% 7.51ms 6.96ms 🟢 -7.41% 🟢 12%
execute/
factorial/iter
245.60µs 263.05µs 🔴 7.10% 309.42µs 312.70µs ⚪ 1.06% 🟢 19%
execute/
factorial/rec
683.16µs 679.40µs ⚪ -0.55% 1.25ms 1.26ms ⚪ 0.57% 🟡 86%
execute/
fibonacci/iter
1.28ms 1.30ms ⚪ 1.06% 1.26ms 1.26ms ⚪ 0.09% 🟢 -3%
execute/
fibonacci/rec
6.30ms 6.09ms 🟢 -3.22% 12.99ms 13.15ms ⚪ 1.21% 🔴 116%
execute/
fibonacci/tail
1.36ms 1.36ms ⚪ 0.18% 3.61ms 3.68ms 🔴 2.02% 🔴 171%
execute/
fuse
7.37ms 7.39ms ⚪ 0.34% 11.39ms 11.41ms ⚪ 0.16% 🟡 54%
execute/
global/bump
1.32ms 1.32ms ⚪ 0.16% 1.54ms 1.54ms ⚪ 0.00% 🟢 17%
execute/
global/get_const
712.12µs 712.64µs ⚪ 0.07% 749.96µs 750.63µs ⚪ 0.09% 🟢 5%
execute/
is_even/rec
1.09ms 1.09ms ⚪ 0.13% 2.19ms 2.20ms ⚪ 0.36% 🔴 102%
execute/
memory/fill_bytes
1.08ms 1.08ms ⚪ -0.22% 1.32ms 1.32ms ⚪ 0.16% 🟢 22%
execute/
memory/sum_bytes
1.09ms 1.10ms ⚪ 0.86% 1.25ms 1.25ms ⚪ 0.33% 🟢 14%
execute/
memory/vec_add
2.95ms 2.95ms ⚪ -0.06% 3.62ms 3.61ms ⚪ -0.37% 🟢 22%
execute/
recursive_scan
187.56µs 188.88µs ⚪ 0.70% 379.24µs 380.84µs ⚪ 0.42% 🔴 102%
execute/
recursive_trap
15.45µs 15.59µs ⚪ 0.90% 33.99µs 34.43µs 🔴 1.29% 🔴 121%
execute/
regex_redux
591.90µs 592.69µs ⚪ 0.13% 1.05ms 1.04ms ⚪ -0.65% 🟡 75%
execute/
rev_complement
444.88µs 443.97µs ⚪ -0.21% 631.42µs 632.19µs ⚪ 0.12% 🟢 42%
execute/
tiny_keccak
349.44µs 349.79µs ⚪ 0.10% 377.58µs 377.78µs ⚪ 0.05% 🟢 8%
execute/
trunc_f2i
616.50µs 617.32µs ⚪ 0.13% 962.70µs 962.49µs ⚪ -0.02% 🟡 56%
instantiate/
wasm_kernel
55.80µs 51.80µs 🟢 -7.17% 56.31µs 55.63µs ⚪ -1.20% 🟢 7%
overhead/
call/typed/0
1.21ms 1.42ms 🔴 16.93% 762.68µs 772.97µs 🔴 1.35% 🟢 -45%
overhead/
call/typed/16
1.59ms 1.67ms 🔴 5.00% 1.92ms 1.91ms ⚪ -0.79% 🟢 14%
overhead/
call/untyped/0
1.60ms 1.72ms 🔴 7.24% 1.21ms 1.21ms ⚪ 0.23% 🟢 -30%
overhead/
call/untyped/16
2.57ms 2.56ms ⚪ -0.20% 3.87ms 3.86ms ⚪ -0.12% 🟡 51%
translate/
bz2/checked/default
1.40ms 1.41ms ⚪ 0.35% 2.64ms 2.65ms ⚪ 0.40% 🟡 88%
translate/
bz2/checked/fuel
1.46ms 1.46ms ⚪ 0.03% 2.77ms 2.78ms ⚪ 0.22% 🟡 91%
translate/
bz2/unchecked/default
1.12ms 1.13ms ⚪ 0.68% 2.01ms 2.01ms ⚪ 0.02% 🟡 78%
translate/
bz2/unchecked/fuel
1.17ms 1.18ms ⚪ 1.10% 2.14ms 2.14ms ⚪ 0.25% 🟡 82%
translate/
erc1155/checked/default
285.76µs 286.63µs ⚪ 0.30% 510.69µs 510.23µs ⚪ -0.09% 🟡 78%
translate/
erc1155/checked/fuel
305.38µs 307.67µs ⚪ 0.75% 540.79µs 536.58µs ⚪ -0.78% 🟡 74%
translate/
erc1155/unchecked/default
232.74µs 235.11µs ⚪ 1.02% 396.21µs 395.59µs ⚪ -0.16% 🟡 68%
translate/
erc1155/unchecked/fuel
250.94µs 254.17µs ⚪ 1.29% 421.99µs 419.47µs ⚪ -0.59% 🟡 65%
translate/
erc20/checked/default
138.80µs 140.38µs ⚪ 1.14% 245.08µs 244.64µs ⚪ -0.18% 🟡 74%
translate/
erc20/checked/fuel
147.33µs 147.36µs ⚪ 0.02% 255.56µs 253.59µs ⚪ -0.77% 🟡 72%
translate/
erc20/unchecked/default
112.90µs 113.07µs ⚪ 0.16% 189.99µs 191.30µs ⚪ 0.69% 🟡 69%
translate/
erc20/unchecked/fuel
120.38µs 121.22µs ⚪ 0.70% 201.10µs 198.98µs ⚪ -1.05% 🟡 64%
translate/
erc721/checked/default
197.72µs 197.96µs ⚪ 0.12% 355.27µs 354.52µs ⚪ -0.21% 🟡 79%
translate/
erc721/checked/fuel
208.16µs 208.02µs ⚪ -0.06% 367.77µs 366.39µs ⚪ -0.37% 🟡 76%
translate/
erc721/unchecked/default
159.64µs 159.71µs ⚪ 0.05% 271.96µs 270.78µs ⚪ -0.43% 🟡 70%
translate/
erc721/unchecked/fuel
169.58µs 169.27µs ⚪ -0.18% 284.55µs 284.68µs ⚪ 0.04% 🟡 68%
translate/
pulldown_cmark/checked/default
3.86ms 3.84ms ⚪ -0.55% 6.78ms 6.78ms ⚪ 0.04% 🟡 76%
translate/
pulldown_cmark/checked/fuel
3.91ms 3.93ms ⚪ 0.44% 7.06ms 7.05ms ⚪ -0.10% 🟡 80%
translate/
pulldown_cmark/unchecked/default
3.10ms 3.12ms ⚪ 0.60% 5.23ms 5.27ms ⚪ 0.76% 🟡 69%
translate/
pulldown_cmark/unchecked/fuel
3.20ms 3.22ms ⚪ 0.57% 5.50ms 5.52ms ⚪ 0.52% 🟡 72%
translate/
spidermonkey/checked/default
89.53ms 89.42ms ⚪ -0.13% 164.87ms 163.33ms ⚪ -0.94% 🟡 83%
translate/
spidermonkey/checked/fuel
92.51ms 92.56ms ⚪ 0.05% 171.56ms 170.10ms ⚪ -0.85% 🟡 84%
translate/
spidermonkey/unchecked/default
71.84ms 71.59ms ⚪ -0.36% 124.12ms 124.63ms ⚪ 0.41% 🟡 74%
translate/
spidermonkey/unchecked/fuel
74.43ms 75.35ms ⚪ 1.24% 130.50ms 130.62ms ⚪ 0.09% 🟡 73%
translate/
wasm_kernel/checked/default
5.11ms 5.11ms ⚪ 0.11% 9.20ms 9.08ms 🟢 -1.23% 🟡 78%
translate/
wasm_kernel/checked/fuel
5.25ms 5.28ms ⚪ 0.49% 9.53ms 9.44ms ⚪ -0.91% 🟡 79%
translate/
wasm_kernel/unchecked/default
4.08ms 4.10ms ⚪ 0.51% 6.99ms 7.00ms ⚪ 0.11% 🟡 71%
translate/
wasm_kernel/unchecked/fuel
4.24ms 4.25ms ⚪ 0.29% 7.34ms 7.35ms ⚪ 0.10% 🟡 73%

Link to pipeline

@Robbepop Robbepop merged commit dc5076f into master Dec 8, 2023
20 checks passed
@Robbepop Robbepop deleted the rf-improve-ci branch December 8, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants