Add verbose mode to wasmi cli #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbepop
reviewed
Mar 14, 2024
crates/cli/src/args.rs
Outdated
Comment on lines
98
to
101
|
|
||
| /// Enable informational messages beyond warnings or errors. | ||
| #[clap(long = "verbose")] | ||
| verbose: bool, |
There was a problem hiding this comment.
I am not 100% sure but I think it is important that the func_args field comes last since it takes a variable number of arguments. So please move the verbose field before it.
There was a problem hiding this comment.
Sounds fine. Change made.
There was a problem hiding this comment.
Also, if you'd prefer restricting the remaining fuel message to verbose mode already, let me know, and I can do that, too.
tjpalmer
commented
Mar 14, 2024
Glad to help! Looking forward to the next release! Wasmi is a great project for up-to-date lightweight wasm support. (At least fairly up-to-date with good maintenance and a nice roadmap.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #955.
This prevents the initial "executing File ..." message unless
--verboseis set.The only other informational message I found was the remaining fuel message. I didn't require verbose for this, since it already depends on the fuel option. But it's something to consider in the future perhaps.