-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize wasmi::Linker
host function setup
#989
Merged
Merged
Commits on Apr 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b45d89b - Browse repository at this point
Copy the full SHA b45d89bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d34b25 - Browse repository at this point
Copy the full SHA 4d34b25View commit details -
implement LenOrder and LenOrderStr string wrappers
According to our benchmarks those string type wrappers and their custom Ord implementation improve Linker performance by roughly 50%. This is probably because the Rust compiler is able to inline the `memcmp` routines whereas with `Arc<str>` and `str` it uses `memcmp` calls which are inefficient for small strings.
Configuration menu - View commit details
-
Copy full SHA for 75b1706 - Browse repository at this point
Copy the full SHA 75b1706View commit details
Commits on Apr 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f099e3c - Browse repository at this point
Copy the full SHA f099e3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0159b5 - Browse repository at this point
Copy the full SHA d0159b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2965e9f - Browse repository at this point
Copy the full SHA 2965e9fView commit details -
The new implementation optimizes the Ord impl of ImportKey since ImportKeys are compared more often than their fields are queried during Linker setup.
Configuration menu - View commit details
-
Copy full SHA for 5be3b35 - Browse repository at this point
Copy the full SHA 5be3b35View commit details -
use FuncType instead of DedupFuncType in HostFuncTrampolineEntity
This allows us to create new HostFuncTrampolineEntities without an Engine and thus allow for a HostApi abstraction later to further optimize Linker setup. Also conveniently this allow us to get rid of tons of custom Debug implementations to resolve the no longer existing DedupFuncTypes.
Configuration menu - View commit details
-
Copy full SHA for 21effcd - Browse repository at this point
Copy the full SHA 21effcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c61abc4 - Browse repository at this point
Copy the full SHA c61abc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45f0ed9 - Browse repository at this point
Copy the full SHA 45f0ed9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92aea8d - Browse repository at this point
Copy the full SHA 92aea8dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.