Support Rust files in wat2wasm4cpp.py script #704
Conversation
gumb0
force-pushed
the
wat2wasm4rs
branch
2 times, most recently
from
14f80bc
to
e547964
Compare
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 73 73
Lines 10883 10883
=======================================
Hits 10804 10804
Misses 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. |
Yes that is a bit annoying, but still better to have this automated. |
| ./wat2wasm4tests.py test/unittests/validation_test.cpp | ||
| ./wat2wasm4tests.py test/unittests/wasm_engine_test.cpp | ||
| ./wat2wasm4tests.py test/spectests/spectests.cpp | ||
| ./wat2wasm4tests.py test/testfloat/testfloat.cpp | ||
| git diff --color --exit-code |
There was a problem hiding this comment.
Should also add bindings/rust/src/lib.rs to the CI.
| @@ -31,10 +31,16 @@ | |||
| WAT2WASM_TOOL = 'wat2wasm' | |||
| WAT2WASM_DEFAULT_OPTIONS = ['--disable-saturating-float-to-int', | |||
| '--disable-sign-extension', '--disable-multi-value'] | |||
| FORMAT_TOOL = 'clang-format' | |||
| CPP_FORMAT_TOOL = ['clang-format', '-i'] | |||
| RS_FORMAT_TOOL = ['rustfmt'] | |||
There was a problem hiding this comment.
Did you try this on ci? Doesn't it need to be installed on the run?
There was a problem hiding this comment.
There was a problem hiding this comment.
Actually it would ignore failures if rustfmt were not found, let me check it then.
There was a problem hiding this comment.
You were right, it didn't work. I fixed it by moving into bindings-rust job, where it's already installed (but then wabt needs to be installed there, too)
gumb0
force-pushed
the
wat2wasm4rs
branch
4 times, most recently
from
30711b7
to
d7530f0
Compare
gumb0
force-pushed
the
wat2wasm4rs
branch
5 times, most recently
from
dbe4034
to
0f4dc74
Compare
| @@ -35,7 +35,7 @@ commands: | |||
| else | |||
| [[ $OSTYPE = darwin* ]] && os=macos || os=ubuntu | |||
| cd /usr/local | |||
| curl -L https://github.com/WebAssembly/wabt/releases/download/1.0.20/wabt-1.0.20-$os.tar.gz | sudo tar xz --strip 1 | |||
| curl -L https://github.com/WebAssembly/wabt/releases/download/1.0.20/wabt-1.0.20-$os.tar.gz | (sudo tar xz --strip 1 || tar xz --strip 1) | |||
There was a problem hiding this comment.
This solves the problem of sudo not working in Rust docker (user is already root there), probably there are more elegant ways to solve it, but this works.
There was a problem hiding this comment.
It might be better to migrate to cimg/rust where build are probably not executed as root and there may be more CI related benefits.
circle.yml
Outdated
| name: Check wat2wasm4tests | ||
| command: | | ||
| rustfmt --version | ||
| ./wat2wasm4tests.py bindings/rust/src/lib.rs |
There was a problem hiding this comment.
Why not use find here too (like for C++)?
Closes #593.
I used
rustfmtbecaust it takes a single file as argument.However, it doesn't seem much useful, e.g. long hex strings are not broken down (this option is unstable and off by default
https://rust-lang.github.io/rustfmt/?version=v1.4.33&search=#format_strings
rust-lang/rustfmt#3353)