Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASI imports #199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WASI imports #199

wants to merge 1 commit into from

Conversation

g-r-a-n-t
Copy link

Addresses #178

Added a new import list identified by "wasi", which contains all of the the functions listed in the latest API snapshot.

@jakelang jakelang requested a review from axic July 13, 2020 00:45
jakelang
jakelang approved these changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@jakelang jakelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for the delayed review. LGTM, just replace the .unwrap() instances in the tests with expect() and some panic messages and it's all good.

@g-r-a-n-t
Wasi imports.
ac91223 
Updated for multi func results.

Revert "Updated for multi func results."

This reverts commit 5e9b051.

All wasi imports.

Formatting.

cleanup
@g-r-a-n-t
Copy link
Author

Should be good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelang jakelang jakelang approved these changes

@axic axic Awaiting requested review from axic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-r-a-n-t @jakelang