Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remap externalCodeCopy #84

Merged
merged 1 commit into from
Apr 6, 2019
Merged

Remap externalCodeCopy #84

merged 1 commit into from
Apr 6, 2019

Conversation

s1na
Copy link
Collaborator

@s1na s1na commented Apr 5, 2019

No description provided.

@s1na s1na mentioned this pull request Apr 5, 2019
Merged
@jakelang
Copy link
Collaborator

jakelang commented Apr 5, 2019

Hi Sina,
Thanks for the PR!
This is covered in the refactor PR for remapImports, #66.

@jakelang jakelang added the duplicate This issue or pull request already exists label Apr 5, 2019
jakelang
jakelang approved these changes Apr 5, 2019
View reviewed changes
Copy link
Collaborator

@jakelang jakelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-emptively approving this just in case it is needed urgently for RuneVM.

@axic axic merged commit 1960f58 into wasmx:master Apr 6, 2019
@s1na s1na deleted the fix/extcodecopy-import branch April 6, 2019 09:11
@s1na
Copy link
Collaborator Author

s1na commented Apr 6, 2019

Sorry I hadn't seen that! thanks for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelang jakelang jakelang approved these changes

Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s1na @jakelang @axic