Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helmet to node server dependencies #239

Merged
merged 1 commit into from
May 19, 2021
Merged

Conversation

caz-gh
Copy link
Contributor

@caz-gh caz-gh commented May 18, 2021

Description

Added Helmet 4.6.0 (latest) to the list of node dependencies. The default config options are used, and more info on which response headers are set by default can be seen here.

Here are the response headers when using Helmet on a new Wasp app:

Screenshot from 2021-05-18 17-12-10

And here are the response headers without Helmet on a new Wasp app:

Screenshot from 2021-05-18 17-32-29

Fixes #22

Type of change

Please select the option(s) that is more relevant.

  • Code cleanup
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@Martinsos Martinsos merged commit 179ff5c into wasp-lang:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using 'helmet' npm package in node server
2 participants