Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing DaemonSet and StatefulSet permissions to Kustomize example #72

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

Lngramos
Copy link
Contributor

@Lngramos Lngramos commented Oct 17, 2019

Ensure that the example Kustomize config is in sync with the other (auto-generated) example config, by adding the missing DaemonSet and StatefulSet RBAC permissions.

p.s. the Kustomize config does not appear to be auto-generated by the make manifest command.

Aims to resolve issue: #63

@pusher-ci
Copy link

Hi @Lngramos. Thanks for your PR.

I'm waiting for a pusher member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Lngramos Lngramos changed the title Add missing DaemonSet and StatefulSet permissions in example Add missing DaemonSet and StatefulSet permissions to Kustomize example Oct 18, 2019
Copy link
Collaborator

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now matches the generated RBAC by the looks of it, LGTM! Thanks for your contribution! 🎉

@JoelSpeed
Copy link
Collaborator

/ok-to-test

@JoelSpeed
Copy link
Collaborator

/retest

Some flaky tests :/

@JoelSpeed JoelSpeed merged commit 6a4a1a0 into wave-k8s:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants