Tighten up function detection to look for polyfills. Relax Barcode ap…

…i check
wavebox · Mar 9, 2021 · a1212dc · a1212dc
1 parent a6094cd
commit a1212dc
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/dist/chromium-detector.js b/dist/chromium-detector.js
diff --git a/index.js b/index.js
@@ -2,7 +2,13 @@
  * @param v: value to check
  * @return true if the value is of type function
  */
-const isFunction = (v) => typeof (v) === 'function'
+const isFunction = (v) => {
+  return (
+    typeof (v) === 'function' &&
+    typeof (v.toString) === 'function' &&
+    v.toString().includes('[native code]')
+  )
+}
 
 /**
  * @param v: value to check
@@ -216,6 +222,7 @@ const descriptors = {
       {
         url: 'https://chromestatus.com/feature/4757990523535360',
         name: 'Barcode Detection API',
+        optional: true, // Some electron instances don't implement this
         test: () => isFunction(window.BarcodeDetector)
       },
       {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "chromium-detector",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Feature detects the running version of Chromium without any UserAgent parsing",
   "main": "dist/chromium-detector.js",
   "module": "index.js",