Handle data from DataDog of type:rate #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basilisk487
reviewed
Feb 18, 2020
| JsonNode type = metric.get("type"); | ||
| if (type != null) { | ||
| if (type.textValue().equals("rate")) { | ||
| interval = metric.get("interval") == null ? 1 : metric.get("interval").intValue(); |
There was a problem hiding this comment.
We probably want to handle bad data scenarios where "interval" field is not numeric
basilisk487
suggested changes
Feb 18, 2020
basilisk487
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When DataDog sends statsd counter data the JSON contains a value that when displayed by DataDog is multiplied by the "interval" property supplied in the JSON.
This change allows Wavefront to store and render that same value. The modified value also matches what the telegraf statsd input plugin sends for the same DogStatsD data so this seems to be a quirk of how DataDog sends and parses the data.