PUB-218 enhanced preprocessor rules. #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akodali18
force-pushed
the
enhanced-preprocessor-rules
branch
from
5375123 to
2575e14
Compare
basilisk487
suggested changes
Mar 16, 2020
proxy/src/main/java/com/wavefront/agent/preprocessor/PreprocessorUtil.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/wavefront/agent/preprocessor/PreprocessorUtil.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/wavefront/agent/preprocessor/PreprocessorUtil.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/wavefront/agent/preprocessor/PreprocessorUtil.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/wavefront/agent/preprocessor/PreprocessorUtil.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/wavefront/agent/preprocessor/PreprocessorUtil.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/wavefront/agent/preprocessor/PreprocessorConfigManager.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/wavefront/agent/preprocessor/ReportPointAddTagIfNotExistsTransformer.java
Outdated
Show resolved
Hide resolved
Gist: We introduced a new argument denoted in yaml with the key "if", whose value denotes a predicate function. The preprocessor rule will apply to a given entity if this predicate function evaluates to true. We will be calling this as the "v2PredicateKey" and its corresponding predicate function as "v2Predicate". Semantics and behavior changes: 1. v2Predicate applies to all scopes except for "pointline" 2. For "Filtering" preprocessor rules, Previously v1Predicates(i.e. [match], [scope] arguments) were considered mandatory. With this change, v1Predicates are considered optional, if v2Predicate present. However, note that v1Predicates cannot be specified and left blank(this is still considered invalid). If both v1Predicates and v2Predicate is specified, then both need to be satisfied to apply the rule.
akodali18
force-pushed
the
enhanced-preprocessor-rules
branch
from
59899f2 to
7ef0d4b
Compare
basilisk487
reviewed
Mar 27, 2020
proxy/src/main/java/com/wavefront/agent/preprocessor/PreprocessorConfigManager.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/wavefront/agent/preprocessor/ReportPointAddTagTransformer.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/wavefront/agent/preprocessor/ReportPointAddTagTransformer.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/wavefront/agent/preprocessor/ReportPointWhitelistRegexFilter.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/wavefront/agent/preprocessor/predicate/ContainsPredicate.java
Outdated
Show resolved
Hide resolved
basilisk487
reviewed
Mar 27, 2020
proxy/src/main/java/com/wavefront/agent/preprocessor/PreprocessorUtil.java
Outdated
Show resolved
Hide resolved
…fore passing them on to a rule, add unit tests.
TFTR, didn't add unit tests previously to avoid having to rework on them if anything needed change based on your review comments. Added them now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gist:
We introduced a new argument denoted in yaml with the key "if", whose value denotes a predicate function. The preprocessor rule will apply to a given entity if this predicate function evaluates to true. We will be calling this as the "v2PredicateKey" and its corresponding predicate function as "v2Predicate".
Semantics and behavior changes: