Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUB-221: Default proxy port (2878) in HTTP mode should work like DDI endpoint #510

Merged
merged 5 commits into from
Mar 27, 2020
Merged

PUB-221: Default proxy port (2878) in HTTP mode should work like DDI endpoint #510

merged 5 commits into from
Mar 27, 2020

Conversation

basilisk487
Copy link
Contributor

No description provided.

@basilisk487 basilisk487 requested a review from panghy March 26, 2020 23:31
@panghy panghy merged commit 3dd1fa1 into wavefrontHQ:master Mar 27, 2020
@basilisk487 basilisk487 mentioned this pull request Mar 27, 2020
Closed
basilisk487 added a commit that referenced this pull request Apr 2, 2020
@basilisk487
PUB-221: Default proxy port (2878) in HTTP mode should work like DDI …
80d4e63 
…endpoint (#510)

* PUB-221: Default proxy port (2878) in HTTP mode should function like DDI endpoint

* Avoid unnecessary double conversion to string

* Updated as per code review

* Fix annotations

* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panghy panghy panghy approved these changes

@sushantdewan123 sushantdewan123 Awaiting requested review from sushantdewan123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basilisk487 @panghy