Support sampling/filtering of span logs using updated span log data f… #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basilisk487
approved these changes
May 14, 2020
|
LGTM (pending java-lib release) |
srujann
reviewed
May 19, 2020
| } | ||
| List<Span> spanOutput = new ArrayList<>(1); | ||
| try { | ||
| spanDecoder.decode(spanMessage, spanOutput, "dummy"); |
There was a problem hiding this comment.
it doesn't really matter in this context, but we should probably standardize on something like "default" or "unknown"
There was a problem hiding this comment.
yeah, right now i think we're defaulting to "dummy" in most places in the code. let me know if i should change that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ormat