Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"WriteSet can't contain more than" never happens #3758

Draft
wants to merge 2 commits into
base: version-1.4.x
Choose a base branch
from
Draft

"WriteSet can't contain more than" never happens #3758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9515536
Removed a check for "WriteSet can't contain more than ..." error, bec…
vsuharnikov Sep 6, 2022
5508d6e
Added a small note about blacklisting and suspension.
vsuharnikov Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion node/src/main/resources/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ waves {
# If yes the node requests peers and sends known peers
enable-peers-exchange = yes

# If yes the node can blacklist others
# If yes the node can blacklist incoming and outgoing connections to other nodes
enable-blacklisting = yes

# How often connected peers list should be broadcast
Expand All @@ -105,6 +105,7 @@ waves {
# respond in a timely manner, it gets blacklisted.
handshake-timeout = 30s

# The node can't connect to suspended nodes
suspension-residence-time = 1m

# When a new transaction comes from the network, we cache it and doesn't push this transaction again when it comes
Expand Down
5 changes: 0 additions & 5 deletions node/src/main/scala/com/wavesplatform/state/diffs/invoke/InvokeDiffsCommon.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,11 +347,6 @@ object InvokeDiffsCommon {

private def checkDataEntries(blockchain: Blockchain, tx: InvokeScriptLike, dataEntries: Seq[DataEntry[?]], stdLibVersion: StdLibVersion) =
for {
_ <- Either.cond(
dataEntries.length <= ContractLimits.MaxWriteSetSize,
(),
s"WriteSet can't contain more than ${ContractLimits.MaxWriteSetSize} entries"
)
_ <- Either.cond(
tx.enableEmptyKeys || dataEntries.forall(_.key.nonEmpty),
(), {
Expand Down