Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo: @ and ~ #70

Closed
EdenQwQ opened this issue Mar 6, 2022 · 3 comments · Fixed by #87
Closed

Todo: @ and ~ #70

EdenQwQ opened this issue Mar 6, 2022 · 3 comments · Fixed by #87
Labels
Enhancement New feature or request Help wanted Extra attention is needed

Comments

@EdenQwQ
Copy link
Member

EdenQwQ commented Mar 6, 2022

In sxhkd man page:

If @ is added at the beginning of the keysym, the command will be run on key release events, otherwise on key press events.

If ~ is added at the beginning of the keysym, the captured event will be replayed for the other clients.

In the config_devel branch, we've already implemented checking for those prefixes.
As you can see in the struct KeyBinding, there are two bool items send and on_release.
Calling .is_send() or is_on_release() method on struct KeyBinding or Hotkey returns the value respectively.

Need help to actually implement this feature to daemon.rs

@EdenQwQ EdenQwQ added Enhancement New feature or request Help wanted Extra attention is needed labels Mar 6, 2022
@EdenQwQ
Copy link
Member Author

EdenQwQ commented Mar 6, 2022

@angelofallars @Shinyzenith @vainiovano
Please check config_devel branch when convenient

@Shinyzenith
Copy link
Member

I'll work on this later today if when I get time :D

@EdenQwQ
Copy link
Member Author

EdenQwQ commented Mar 6, 2022

I forgot to handle the case where a keysym has both prefixes 🤦

@EdenQwQ EdenQwQ linked a pull request Mar 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Help wanted Extra attention is needed
Development

Successfully merging a pull request may close this issue.

2 participants