Feat: multiple config file loading & '@' '~' prefix #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns for prefix feature
This was
linked to
issues
Mar 10, 2022
Closed
Closed
EdenQwQ
requested review from
Shinyzenith,
angelofallars and
vainiovano
and removed request for
Shinyzenith
Shinyzenith
requested changes
Mar 10, 2022
src/daemon.rs
Outdated
| @@ -216,6 +221,11 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| Some((i, Ok(event))) = keyboard_stream_map.next() => { | |||
| let keyboard_state = &mut keyboard_states[i]; | |||
| if let InputEventKind::Key(key) = event.kind() { | |||
| if last_hotkey.is_some() && pending_release.is_some() && event.value() == 0 && event.code() == pending_release.as_ref().unwrap().keysym().code() { | |||
There was a problem hiding this comment.
If we're checking for event value == 0 anyways, why not put this in the match statement ?
|
I wanted to choose comment type review but the car was shaking, my apologies. |
Shinyzenith
approved these changes
Mar 13, 2022
|
@angelofallars I'm gonna merge since you have already approved this pr. |
|
Oh @EdenQwQ would you mind adding some documentation to readme.md? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.