Collection bricks with fixed heights were infinitely resizing. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thevwu
force-pushed
the
bugfix-collectionBrickFixedHeight
branch
from
24aae18
to
293ba4b
Compare
thevwu
force-pushed
the
bugfix-collectionBrickFixedHeight
branch
from
293ba4b
to
4d53e18
Compare
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 93.47% 93.48% +<.01%
==========================================
Files 38 38
Lines 3034 3038 +4
==========================================
+ Hits 2836 2840 +4
Misses 198 198
Continue to review full report at Codecov.
|
jay18001
suggested changes
Mar 23, 2017
| @@ -145,6 +145,11 @@ public class CollectionBrickCell: BrickCell, Bricklike, AsynchronousResizableCel | |||
| return super.preferredLayoutAttributesFittingAttributes(layoutAttributes) | |||
| } | |||
|
|
|||
| guard self._brick.height.isEstimate else { | |||
jay18001
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue when you have an outer collection brick with a fixed height, and an inner collection brick with an automatic height. When scrolling the outer collection brick, the inner collection brick will keep resizing itself because the outer collection brick is also resizing itself. This merge makes it so that if a collection brick has a fixed height, it will not try to resize itself.
Fixes #109