Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove nock dependency #46

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Fix/remove nock dependency #46

merged 2 commits into from
Oct 18, 2021

Conversation

letlm
Copy link
Contributor

@letlm letlm commented Oct 16, 2021

Proposed Changes

This PR aims to resolve the issue #44 , which mentions that Nock isn't been used.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Test Plan and Documentation

Further comments

Cooperbuilt
Cooperbuilt approved these changes Oct 17, 2021
View reviewed changes
Copy link

@Cooperbuilt Cooperbuilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@Cooperbuilt
Copy link

closes #44

@Cooperbuilt Cooperbuilt merged commit f7127f8 into wayfair:main Oct 18, 2021
@Cooperbuilt Cooperbuilt mentioned this pull request Oct 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cooperbuilt Cooperbuilt Cooperbuilt approved these changes

Assignees
No one assigned
Labels
hacktober-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@letlm @Cooperbuilt