Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase verbosity in npm ci for GitHub Action Checks #48

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Increase verbosity in npm ci for GitHub Action Checks #48

merged 2 commits into from
Oct 22, 2021

Conversation

peterthehan
Copy link
Contributor

Proposed Changes

Changed npm ci to npm ci --loglevel verbose to address #40

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Test Plan and Documentation

Tested this via the PR check in GitHub Actions, noting the increased verbosity in the npm ci logs

@GaryPWhite
Copy link
Collaborator

easy peasy! Could you do me a favor and note in the changelog this change?

@GaryPWhite GaryPWhite merged commit aefcb42 into wayfair:main Oct 22, 2021
@peterthehan peterthehan deleted the npm_i_verbosity branch October 22, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryPWhite GaryPWhite GaryPWhite approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterthehan @GaryPWhite